Skip to content

Commit

Permalink
Replace dates with ISO-8601 (simulationcraft#6223)
Browse files Browse the repository at this point in the history
* Replace dates with ISO

As was apparent here, some files used <day>/<month>/<year> while others use <month>/<day>/<year>. Where it wasn't sure what version was the correct one, I tried to correlated with the original commit date.

Please use ISO-8601 format!

* Found another strangely formatted date
  • Loading branch information
scamille authored Nov 25, 2021
1 parent 54d06fd commit 9254595
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 48 deletions.
4 changes: 2 additions & 2 deletions engine/class_modules/monk/sc_monk.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4681,7 +4681,7 @@ struct revival_t : public monk_heal_t
aoe = -1;

if ( sim->pvp_crit )
base_multiplier *= 2; // 08/03/2016
base_multiplier *= 2; // 2016-08-03
}
};

Expand Down Expand Up @@ -6911,7 +6911,7 @@ void monk_t::create_buffs()
make_buff( this, "storm_earth_and_fire", spec.storm_earth_and_fire )
->add_invalidate( CACHE_PLAYER_DAMAGE_MULTIPLIER )
->add_invalidate( CACHE_PLAYER_HEAL_MULTIPLIER )
->set_can_cancel( false ) // Undocumented hotfix 28/09/2018 - SEF can no longer be canceled.
->set_can_cancel( false ) // Undocumented hotfix 2018-09-28 - SEF can no longer be canceled.
->set_cooldown( timespan_t::zero() );

buff.touch_of_death_ww = new buffs::touch_of_death_ww_buff_t( *this, "touch_of_death_ww", spell_data_t::nil() );
Expand Down
12 changes: 6 additions & 6 deletions engine/class_modules/sc_demon_hunter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2155,7 +2155,7 @@ struct fel_devastation_t : public demon_hunter_spell_t
{
cooldown->reset( true );
p()->proc.darkglare_boon_resets->occur();
// 02/18/2021 -- Added in PTR build
// 2021-02-18 -- Added in PTR build
if ( p()->spec.darkglare_boon_refund->ok() )
{
p()->resource_gain( RESOURCE_FURY, p()->spec.darkglare_boon_refund->effectN( 2 ).resource( RESOURCE_FURY ),
Expand Down Expand Up @@ -2460,7 +2460,7 @@ struct collective_anguish_t : public demon_hunter_spell_t

double composite_crit_chance() const override
{
// 03/15/2020 -- 100% crit rate as of 9.0.5, does not appear to be in any spell data
// 2020-03-15 -- 100% crit rate as of 9.0.5, does not appear to be in any spell data
if ( p()->specialization() == DEMON_HUNTER_VENGEANCE )
return 1.0;

Expand Down Expand Up @@ -3696,7 +3696,7 @@ struct chaos_strike_base_t : public demon_hunter_attack_t
assert( eff.type() == E_TRIGGER_SPELL );
background = dual = true;

// 06/22/21 -- It once again appears that Onslaught procs can proc refunds
// 2021-06-22 -- It once again appears that Onslaught procs can proc refunds
may_refund = ( weapon == &( p->off_hand_weapon ) );
if ( may_refund )
{
Expand Down Expand Up @@ -3731,7 +3731,7 @@ struct chaos_strike_base_t : public demon_hunter_attack_t
demon_hunter_attack_t::execute();

// Technically this appears to have a 0.5s ICD, but this is handled elsewhere
// 06/22/2021 -- It once again appears that Onslaught procs can proc refunds, as the procs are now 600ms apart
// 2021-06-22 -- It once again appears that Onslaught procs can proc refunds, as the procs are now 600ms apart
if ( may_refund && p()->rng().roll( this->get_refund_proc_chance() ) )
{
p()->resource_gain( RESOURCE_FURY, p()->spec.chaos_strike_fury->effectN( 1 ).resource( RESOURCE_FURY ), parent->gain );
Expand Down Expand Up @@ -4405,7 +4405,7 @@ struct throw_glaive_t : public demon_hunter_attack_t
// For SimC purposes, using a cloned spell for better stats tracking
if ( hit_any_target && fel_bombardment && bombardment_stacks > 0 )
{
// 12/03/2020 - Apparently hotfixed to work correctly, although it still doesn't work how it did on beta
// 2020-12-03 - Apparently hotfixed to work correctly, although it still doesn't work how it did on beta
// For each stack, pick a new target and trigger a glaive until we run out of targets
const auto targets_in_range = targets_in_range_list( target_list() );
for ( auto bombardment_target : targets_in_range )
Expand Down Expand Up @@ -4989,7 +4989,7 @@ void demon_hunter_t::create_buffs()
// Fake Growing Inferno buff for tracking purposes
buff.growing_inferno = make_buff<buff_t>( this, "growing_inferno", conduit.growing_inferno )
->set_default_value( conduit.growing_inferno.percent() )
// 12/02/2020 - Manual hotfix, not in spell data
// 2020-12-02 - Manual hotfix, not in spell data
->set_max_stack( conduit.growing_inferno->ok() ? (int)( 10 / conduit.growing_inferno.percent() ) : 1 )
->set_duration( 20_s );

Expand Down
4 changes: 2 additions & 2 deletions engine/class_modules/sc_hunter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1569,7 +1569,7 @@ struct hunter_main_pet_t final : public hunter_main_pet_base_t
resource_regen_per_second( RESOURCE_FOCUS ) );
const auto time_to_cd = active.basic_attack -> cooldown -> remains();
const auto remains = std::max( time_to_cd, time_to_fc );
// 23/07/2018 - hunter pets seem to have a "generic" lag of about .6s on basic attack usage
// 2018-07-23 - hunter pets seem to have a "generic" lag of about .6s on basic attack usage
const auto delay_mean = o() -> options.pet_basic_attack_delay;
const auto delay_stddev = 100_ms;
const auto lag = o() -> bugs ? rng().gauss( delay_mean, delay_stddev ) : 0_ms;
Expand Down Expand Up @@ -2825,7 +2825,7 @@ namespace death_chakram
* Min Max Median Avg Stddev
* 0.59 0.711 0.631 0.635 0.0242
*
* 2020.08.11 Additional tests performed by Ghosteld, Putro, Tirrill & Laquan:
* 2020-08-11 Additional tests performed by Ghosteld, Putro, Tirrill & Laquan:
* https://www.warcraftlogs.com/reports/F9ZKyQf7LWxD4vqJ
* Observations:
* - aoe reach is 8 yards
Expand Down
Loading

0 comments on commit 9254595

Please sign in to comment.