[HttpKernel] Fix race condition when clearing old containers

7ochem · Nov 29, 2017 · 9d553f5 · 9d553f5
1 parent 1f14f4d
commit 9d553f5
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php
@@ -644,19 +644,18 @@ protected function initializeContainer()
             return;
         }
 
-        if ($oldContainer) {
+        if ($oldContainer && get_class($this->container) !== $oldContainer->name) {
             // Because concurrent requests might still be using them,
             // old container files are not removed immediately,
             // but on a next dump of the container.
             $oldContainerDir = dirname($oldContainer->getFileName());
             foreach (glob(dirname($oldContainerDir).'/*.legacyContainer') as $legacyContainer) {
-                if (@unlink($legacyContainer)) {
+                if ($oldContainerDir.'.legacyContainer' !== $legacyContainer && @unlink($legacyContainer)) {
                     (new Filesystem())->remove(substr($legacyContainer, 0, -16));
                 }
             }
-            if (get_class($this->container) !== $oldContainer->name) {
-                touch($oldContainerDir.'.legacyContainer');
-            }
+
+            touch($oldContainerDir.'.legacyContainer');
         }
 
         if ($this->container->has('cache_warmer')) {