Skip to content

Tags: 9at8/vscode-go

Tags

v0.15.0

Toggle v0.15.0's commit message
[release] src/goPath: remove dependency on util that depends on vscode

golang.org/cl/239697 accidentally added the new dependency on util - to find
the value of go.goroot, which broke the debug adapter that runs outside
vscode.

Made getBinPathWithPreferredGopath accept a preferredGoroot param,
and renamed the function to reflect this change.

We need to remove any dependency from src/debugAdapter to src to avoid
a similar bug in the future.

We need to have a test, using the built extension.

Updates golang#137.

Change-Id: I586438f1f391aaff0c0cdc806de1e9f3fd5deba9
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240097
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit b9d1bad)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240117

v0.15.0-rc.3

Toggle v0.15.0-rc.3's commit message
[release] src/goPath: remove dependency on util that depends on vscode

golang.org/cl/239697 accidentally added the new dependency on util - to find
the value of go.goroot, which broke the debug adapter that runs outside
vscode.

Made getBinPathWithPreferredGopath accept a preferredGoroot param,
and renamed the function to reflect this change.

We need to remove any dependency from src/debugAdapter to src to avoid
a similar bug in the future.

We need to have a test, using the built extension.

Updates golang#137.

Change-Id: I586438f1f391aaff0c0cdc806de1e9f3fd5deba9
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240097
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit b9d1bad)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240117

v0.15.0-rc.2

Toggle v0.15.0-rc.2's commit message
[release] src/goInstallTools.ts: fix PATH adjustment when a different…

… go is chosen

With commits d93a0ae and a5e40ca (microsoft/vscode-go#3152), we tried to
include the go binary's path to the PATH (Path on windows) in order to ensure
all underlying go tools (gofmt, cgo, gopls, ...) that simply invoke 'go'
can find the matching go binary by searching the PATH.

We found that trick does not work when users specifies a different go version
using go.alternateTools and the specified binary is not named 'go'.
For example, golang.org provides an easy way to install extra versions of Go
https://golang.org/doc/install#extra_versions through a wrapper, whose
name includes the version. Users who take this approach should be able to
configure to pick up the chosen version with

```
  "go.alternateTools": {
     "go": "/Users/username/go/bin/go1.13.11"
  }
```

Previously, we just added /Users/username/go/bin (the go binary directory name)
to PATH. Because there is no 'go' binary in this directory, the underlying
tools failed to pick the right go tool.

In this CL, we instead use the GOROOT (found from go env call) and add
GOROOT/bin to the PATH.

In this CL

- We also arrange to call updateGoVarsFromConfig only when the relevant
configs are changed (onDidChangeConfiguration setup in goMain.ts).
Previously, this was called almost on every file save events if the repository
has a workspace setting file (.vscode/setting.json).

- We also changed initGoStatusBar to be called after the goroot is updated.
That eliminates an extra call path (initGoStatusBar -> ... -> updateGoVarsFromConfig,
and also, reflects goroot changes correctly when the configuration is updated.

Updates golang#146
Updates golang#26

Change-Id: I9b0e42787308e17547067460960b5fdd8b678991
GitHub-Last-Rev: 995c1a3
GitHub-Pull-Request: golang#252
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/239697
Reviewed-by: Brayden Cloud <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit 057186f)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/239981

v0.15.0-rc.1

Toggle v0.15.0-rc.1's commit message
[release] .github/workflows: add a new release workflow

This creates a new "release" workflow to execute the release of golang.go extension.
(release.yml). The nightly release workflow was moved to release-nightly.yml in
the previous commit.

The new release workflow is triggered when a new tag on the release branch is pushed.

Note: our canonical repository is in go.googlesource.com/vscode-go and tagging
will be done in the canonical repository, and mirrored to the github repository.
A typical workflow will be like

1. A human operator creates a CL to merge the main dev branch to the 'release' branch.
   CI (GCB builder) will test the CL.
2. The CL is reviewed and merged. This triggers the "Long test workflow" (test-long.yml).
3. The human operator verifies the "Long test workflow" is green.
   Otherwise, fix (fix, cherry-pick, review, commit) on the 'release' branch.
4. When the 'release' branch reaches to the state ready for the release,
   the human operator will tag the commig from the canonical repository.
   (https://go-review.googlesource.com/admin/repos/vscode-go,tags)
   Stable versions should be in the format of 'vX.X.X' (e.g. v0.15.0)
   Release candidates should be in the format of 'vX.X.X-rc.X' (e.g. v0.15.0-rc.1)
5. The gopherbot will mirror the tag to the GitHub repo, and that push will trigger
   the 'Release (golang.go)' workflow specified in this file.
     - For stable version release (vX.X.X), check if the package.json has the matching version.
     - Packaging using 'vsce package'
     - Create a release in Github
     - Upload the vsix file as an asset of the release
     - For stable version release (vX.X.X), upload to the vscode market place
       (not implemented in this CL)

And also, prevent workflows from running in forks.

Change-Id: Idb62c63dac064cd1cca8f87eacdfe87c029a49bf
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/239177
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit f5eb6ed)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/239357
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>

20200616

Toggle 20200616's commit message
[dev.go2go] goLanguageServer.ts: add support for .go2 files with gopls

This change checks if the user has a version of go that supports go2go,
and if so, translates URIs as they go between the extension and the
language server.

It is definitely excessive to stat files up to 2 times every time they
are requested, but caching known files gets us into difficult territory
with deletions, renames, etc. I'd rather avoid it and sacrifice a little
speed.

Change-Id: I8c1e2a1973e9715c16a772bffe46fe7d3cb4b341
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/238244
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>

v0.14.4

Toggle v0.14.4's commit message
[release] docs: automatically generate documentation for settings

Write a script to automatically generate settings and command
documentation using the package.json.

Also, delete the smoke-test.md file in the project root. Not sure how it
got there - probably I messed something up while renaming it.

Change-Id: I229f322d6c45bc81a456f5deb534f6591f3917d9
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236963
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
(cherry picked from commit 8a697ee)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237159

v0.14.4-rc.3

Toggle v0.14.4-rc.3's commit message
[release] docs: automatically generate documentation for settings

Write a script to automatically generate settings and command
documentation using the package.json.

Also, delete the smoke-test.md file in the project root. Not sure how it
got there - probably I messed something up while renaming it.

Change-Id: I229f322d6c45bc81a456f5deb534f6591f3917d9
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236963
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
(cherry picked from commit 8a697ee)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237159

v0.14.4-rc.2

Toggle v0.14.4-rc.2's commit message
[release] README.md: change links to be rendered correctly in vscode

When this is used for extension's Details page inside the vscode,
these links don't render properly. Maybe the markdown renderer used
for the extension info page has a bug. I observed the issue only in this
line where multiple such links are used.

Use the inlined form instead.

Change-Id: I003ac344cb3449453277335d953e640c8b1f13b4
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237077
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit 9f328b7)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236965

v0.14.4-rc1

Toggle v0.14.4-rc1's commit message
[release] Update LICENSE/CHANGELOG/README

Change-Id: I4c070a5fe06910f6a77ad8de28a31340b9986bb6
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236747
Reviewed-by: Rebecca Stambler <[email protected]>