Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP client #1

Merged
merged 27 commits into from
Dec 25, 2018
Merged

HTTP client #1

merged 27 commits into from
Dec 25, 2018

Conversation

9seconds
Copy link
Owner

This PR creates httransform own HTTP client. This is required until fasthttp implements streaming of bodies back to the client.

@codecov-io
Copy link

codecov-io commented Dec 25, 2018

Codecov Report

Merging #1 into master will decrease coverage by 5.88%.
The diff coverage is 71.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #1      +/-   ##
=========================================
- Coverage   87.59%   81.7%   -5.89%     
=========================================
  Files          14      21       +7     
  Lines         774    1159     +385     
=========================================
+ Hits          678     947     +269     
- Misses         66     162      +96     
- Partials       30      50      +20
Impacted Files Coverage Δ
client/pools.go 100% <100%> (ø)
http_clients.go 36.84% <27.27%> (-35.16%) ⬇️
client/dialer.go 28.57% <28.57%> (ø)
client/client.go 45.76% <45.76%> (ø)
executor.go 75.75% <66.66%> (+4.32%) ⬆️
client/pooled_dialer.go 74.07% <74.07%> (ø)
client/readers.go 83.58% <83.58%> (ø)
client/simple_dialer.go 90% <90%> (ø)
client/conns.go 95% <95%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c1d82...8b89d2e. Read the comment docs.

@9seconds 9seconds merged commit de13ff6 into master Dec 25, 2018
@9seconds 9seconds deleted the conns branch December 25, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants