Added $isLinux to output CRLF instead of LF #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faculty seems to sync ok, but the files for the student import would not pass ingestion checks since the files were being generated with UNIX new lines rather than dos new lines. Updated faculty just to be safe.
|
While this seems to export the proper file, it still isn't being ingested. I'll update later... |
|
This does actually work. Apparently, they didn't clear the uploads when I asked for it, so the ingestion was a day behind. This works as it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faculty seems to sync ok, but the files for the student import would not pass ingestion checks since the files were being generated with UNIX new lines rather than dos new lines.
Updated faculty just to be safe.
This could probably be added to the pipeline, but I thought this might be cleaner...