Skip to content

Commit

Permalink
makefile: dont call destructive 'uninstall' on clean (#16540)
Browse files Browse the repository at this point in the history
The 'clean' rule calls 'uninstall', which attemts ***destructive***
operation in the host system and fails if run as unprivileged user.

PR-URL: npm/npm#16540
Credit: @metux
Reviewed-By: @iarna
Reviewed-By: @zkat
  • Loading branch information
metux authored and zkat committed Mar 8, 2018
1 parent b2a1cf0 commit 8150dd5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ dev: install
link: uninstall
node bin/npm-cli.js link -f

clean: markedclean marked-manclean doc-clean uninstall
clean: markedclean marked-manclean doc-clean
rm -rf npmrc
node bin/npm-cli.js cache clean

Expand Down

0 comments on commit 8150dd5

Please sign in to comment.