Fix undefined reference to __version__ in setup.py and remove '# noqa…

…: F821 pylint: disable=undefined-variable'. You can test this fix by changing the 'version' in version.py and then running from the command line: python3 setup.py --version
AbhimanyuAryan · Jan 22, 2018 · 39d614d · 39d614d
1 parent 9a4c50c
commit 39d614d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -19,3 +19,4 @@ dist
 *egg-info*
 npm-debug*
 /.tox
+.idea
diff --git a/setup.py b/setup.py
@@ -1,12 +1,12 @@
 import io
 from setuptools import setup, find_packages
 
-
-exec(open('dash/version.py').read())  # pylint: disable=exec-used
+main_ns = {}
+exec(open('dash/version.py').read(), main_ns)  # pylint: disable=exec-used
 
 setup(
     name='dash',
-    version=__version__,  # noqa: F821 pylint: disable=undefined-variable
+    version=main_ns['__version__'],
     author='chris p',
     author_email='[email protected]',
     packages=find_packages(exclude=['tests*']),
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,3 +19,4 @@ dist @@
     *egg-info*
     npm-debug*
     /.tox
+    .idea