Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix node server localhost #843

Closed
wants to merge 2 commits into from
Closed

fix node server localhost #843

wants to merge 2 commits into from

Conversation

qiweiii
Copy link
Member

@qiweiii qiweiii commented Oct 24, 2024

fix #842

ermalkaleci
ermalkaleci requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@ermalkaleci ermalkaleci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xlc @qiweiii do we need this? there's no problem with the code. it's most likely the user localhost is ipv6. I don't think we should force 127.0.0.1

@ermalkaleci
Copy link
Collaborator

Will be better to add a section on README explaining this rather than forcing 127

@qiweiii
Copy link
Member Author

qiweiii commented Oct 24, 2024

I see, i have

127.0.0.1	localhost
::1             localhost

in my /etc/host, and i'm using a Mac, so this cause the problem, let's just add a section in readme first

@qiweiii qiweiii closed this Oct 24, 2024
@qiweiii qiweiii deleted the fix-node-server branch October 24, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermalkaleci ermalkaleci ermalkaleci requested changes

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection failling version 0.16.2 MacOS
3 participants
@qiweiii @ermalkaleci @xlc