DAO and UpdateTable #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with redis cluster
Conflicts: .gitignore pom.xml src/main/java/com/percero/agents/sync/access/RedisAccessManager.java src/main/java/com/percero/agents/sync/jobs/UpdateTablePoller.java src/main/java/com/percero/agents/sync/services/IDataProvider.java src/main/java/com/percero/agents/sync/services/RedisDataProvider.java src/main/java/com/percero/agents/sync/services/SyncAgentDataProvider.java
Conflicts: pom.xml src/main/java/com/convergys/pulse/service/PulseHttpAuthProvider.java
|
@jonnysamps Can you code review this? It has both the DAODataProvider AND the UpdateTable stuff. I had to merge the two together since changes to the SyncAgentDataProvider I was doing for DAODataProvider had an impact on UpdateTable. |
| // from the class access journal set | ||
| for(String caj : clientAccessJournals){ | ||
| if(cacheDataStore.getSetIsEmpty(RedisKeyUtils.ACCESS_JOURNAL_PREFIX+caj)){ | ||
| String[] parts = caj.split(":"); |
There was a problem hiding this comment.
We do this kind of thing a lot, you should probably refactor that into a helper method. Add it to the ClassIDPair class like
public static ClassIDPair fromCacheKey(String cacheKey){
String[] parts = cacheKey.split(":");
className = parts[0];
ID = parts[1];
}
| } | ||
|
|
||
| @SuppressWarnings({ "unchecked" }) | ||
| private static Map<String, IDataAccessObject<? extends IPerceroObject>> dataAccessObjects = Collections.synchronizedMap(new HashMap<String, IDataAccessObject<? extends IPerceroObject>>()); |
There was a problem hiding this comment.
If this class is singleton you shouldn't use static members. It's redundant.
There was a problem hiding this comment.
Turning this into a spring component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DAODataProvider and UpdateTable functionality