Skip to content

Commit

Permalink
[FLINK-6379] Remove internal methods from MesosResourceManagerGateway
Browse files Browse the repository at this point in the history
Some internal methods which are required for the interplay between the TaskMonitor,
LaunchCoordinator and the MesosResourceManager were exposed as RPC methods. In order
to keep the RPC interface as lean as possible, these methods have been removed.

Fix checkstyle violations
  • Loading branch information
tillrohrmann committed Jun 29, 2017
1 parent 4bb488c commit 901a9ca
Show file tree
Hide file tree
Showing 14 changed files with 289 additions and 444 deletions.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,21 @@

import org.apache.flink.mesos.scheduler.LaunchCoordinator;
import org.apache.flink.mesos.scheduler.ReconciliationCoordinator;
import org.apache.flink.mesos.scheduler.SchedulerGateway;
import org.apache.flink.mesos.scheduler.TaskMonitor;
import org.apache.flink.mesos.scheduler.messages.AcceptOffers;
import org.apache.flink.runtime.resourcemanager.ResourceManagerGateway;

/**
* The {@link MesosResourceManager}'s RPC gateway interface.
* Actions defined by the MesosResourceManager.
*
* <p>These are called by the MesosResourceManager components such
* as {@link LaunchCoordinator}, and {@link TaskMonitor}.
*/
public interface MesosResourceManagerGateway extends ResourceManagerGateway, SchedulerGateway {
public interface MesosResourceManagerActions {

/**
* Accept the given offers as advised by the launch coordinator.
*
* Note: This method is a callback for the {@link LaunchCoordinator}.
* <p>Note: This method is a callback for the {@link LaunchCoordinator}.
*
* @param offersToAccept Offers to accept from Mesos
*/
Expand All @@ -42,7 +43,7 @@ public interface MesosResourceManagerGateway extends ResourceManagerGateway, Sch
/**
* Trigger reconciliation with the Mesos master.
*
* Note: This method is a callback for the {@link TaskMonitor}.
* <p>Note: This method is a callback for the {@link TaskMonitor}.
*
* @param reconciliationRequest Message containing the tasks which shall be reconciled
*/
Expand All @@ -51,7 +52,7 @@ public interface MesosResourceManagerGateway extends ResourceManagerGateway, Sch
/**
* Notify that the given Mesos task has been terminated.
*
* Note: This method is a callback for the {@link TaskMonitor}.
* <p>Note: This method is a callback for the {@link TaskMonitor}.
*
* @param terminatedTask Message containing the terminated task
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.flink.mesos.runtime.clusterframework.store;

import org.apache.flink.runtime.clusterframework.types.ResourceProfile;

import org.apache.mesos.Protos;

import java.io.Serializable;
Expand Down

This file was deleted.

This file was deleted.

Loading

0 comments on commit 901a9ca

Please sign in to comment.