update vin to return randomly generated vin and update tests

AdrieanKhisbe · Oct 15, 2017 · 3303c7e · 3303c7e
1 parent ef6bec4
commit 3303c7e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/lib/vehicle.js b/lib/vehicle.js
@@ -83,11 +83,16 @@ var Vehicle = function (faker) {
    * @method faker.vehicle.vin
    */
   self.vin = function () {
-    return faker.random.arrayElement(faker.definitions.vehicle.vin);
+    return (
+      faker.random.alphaNumeric(10) +
+      faker.random.alpha({ count: 1, upcase: true }) +
+      faker.random.alphaNumeric(1) +
+      faker.random.number({ min: 10000, max: 100000}) // return five digit #
+    ).toUpperCase()
   };
 
   self.vin.schema = {
-    "description": "Generates a VIN number.",
+    "description": "Generates a valid VIN number.",
     "sampleResults": ["YV1MH682762184654", "3C7WRMBJ2EG208836"]
   };
 

diff --git a/test/vehicle.unit.js b/test/vehicle.unit.js
@@ -46,12 +46,9 @@ describe("vehicle.js", function () {
   });
 
   describe("vin()", function () {
-      it("returns a vin number", function () {
-          sinon.stub(faker.vehicle, 'vin').returns('YV1MH682762184654');
-          var vin = faker.vehicle.vin();
-
-          assert.equal(vin, 'YV1MH682762184654');
-          faker.vehicle.vin.restore();
+      it("returns valid vin number", function () {
+        var vin = faker.vehicle.vin();
+        assert.ok(vin.match(/^[A-Z0-9]{10}[A-Z]{1}[A-Z0-9]{1}\d{5}$/));
       });
   });