-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(boot): Fast USDC chain impact #10931
base: master
Are you sure you want to change the base?
Conversation
Deploying agoric-sdk with
|
Latest commit: |
73461e1
|
Status: | ✅ Deploy successful! |
Preview URL: | https://7d31b522.agoric-sdk.pages.dev |
Branch Preview URL: | https://dc-fu-impact.agoric-sdk.pages.dev |
refs: #10890 refs: #10931 ## Description Add a driver to update the block height in fake vstorage cells. Add test of `sequence: false` based deletion. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations Internal test hooks ### Testing Considerations Updated unit tests of fake storage ### Upgrade Considerations None
a137519
to
dd649ce
Compare
I looked at the output using a jupyter notebook. VStorage: ~Flat (64 iterations)lin(impact.vstorageTotalSize[13:])
Exported objects: ~Flatlin(impact.kernelObjects[20:])
lin(impact.clistEntries[20:])
|
Computrons: ~Flatdef unitize(s):
return s / s.max()
lin(unitize(impact1.computrons.dropna())[10:])
Note: techniques for measuring this were drawn from... |
Heap Size: investigating some growth
p.s. escalated to a separate issue: #10955 |
54aba99
to
5eae563
Compare
discovered by running many iterations of the contract and looking at kernel statistics (controller.getStats())
any falsy key, that is
- access kernel stats post bootstrap
flat vstorage! yay!
Diagnosing kernel metric leaks: some in test harness, some in contractInitial measurements showed neither We diagnosed
For {"type":"syscall","crankNum":381,"vatID":"v12","deliveryNum":4,"syscallNum":115,"replay":false,"ksc":["send","ko107",{"methargs":{"body":"#[\"makeNoEscrowSeat\",[{},{\"exit\":{\"onDemand\":null},\"give\":{},\"want\":{}},\"$0.Alleged: ExitObject\",\"$1.Alleged: SeatHandle\"]]","slots":["ko110","ko111"]},"result":"kp134"}],"vsc":["send","o-52",{"methargs":{"body":"#[\"makeNoEscrowSeat\",[{},{\"exit\":{\"onDemand\":null},\"give\":{},\"want\":{}},\"$0.Alleged: ExitObject\",\"$1.Alleged: SeatHandle\"]]","slots":["o+d11/1","o+d10/1"]},"result":"p+7"}],"time":1738634347.628174,"monotime":13.78046653} Some searching for |
Diagnosing VStorage Growth: test harness limitationInitial measurements of vstorage were nowhere near flat either: We diagnosed this as a limitation of the storage mock: |
closes #10890 refs: - #10931 ## Description mainly: - fix: .exit() all internal temporary seats Also, to exercise pruning vstorage: - feat: core eval script to deleteCompletedTxs - expose deleteCompletedTx via creatorFacet To speed up testing and match it with expected deployment: - chore: don't write-chain-info when testing Fast USDC Plus a misc type refinement: - chore: refine return type of Offers.deposit ### Security / Scaling Considerations Reducing leaks improves scalability which improves availability. ### Documentation Considerations I don't think so. ### Testing Considerations Tests are in #10931 ; they're somewhat rough and not included in this PR. ### Upgrade Considerations Some undiagnosed heap growth remains. A fix for that might go out in a future upgrade.
refs:
Description / Scaling / Testing Considerations
Demonstrate that impact on the chain is sustainable:
Security / Documentation Considerations
not much.
Upgrade Considerations
preparation for deployment.
not yet deployed.