ensure that nullable is not set for required parameters (ajv-validato…

…r#2079) nullable was enforced for optional parameters, but not forbidden for required parameters. This tests and enforces the latter case. fixes ajv-validator#2030 Co-authored-by: Evgeny Poberezkin <[email protected]>
Ahmed-Helal-Ahmed · Nov 13, 2022 · 00b3939 · 00b3939
1 parent 69d7897
commit 00b3939
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/types/json-schema.ts b/lib/types/json-schema.ts
@@ -180,6 +180,7 @@ type Nullable<T> = undefined extends T
       default?: T | null
     }
   : {
+      nullable?: false
       const?: T
       enum?: Readonly<T[]>
       default?: T

diff --git a/spec/types/json-schema.spec.ts b/spec/types/json-schema.spec.ts
@@ -306,6 +306,23 @@ describe("JSONSchemaType type and validation as a type guard", () => {
       // eslint-disable-next-line no-void
       void optionalSchema
     })
+
+    it("won't accept nullable for non-null types", () => {
+      // @ts-expect-error can't set nullable
+      const nonNullSchema: JSONSchemaType<{a: number}> = {
+        type: "object",
+        properties: {
+          a: {
+            type: "number",
+            nullable: true,
+          },
+        },
+        required: [],
+      }
+
+      // eslint-disable-next-line no-void
+      void nonNullSchema
+    })
   })
 
   describe("schema works for primitives", () => {