Add support for IP address blocking #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
hansott
approved these changes
Nov 14, 2024
…-blocking * 'beta' of github.com:AikidoSec/node-RASP: (38 commits) Remove console.log(...) Use fake credentials :) Add end2end test for n8n Upgrade to latest zen internals Use v4 of dd-trace (supports node v16 and higher) Add end2end test for compatibility with dd-trace Use fetch helper function instead of native Add comment why we use createServer Make non-owned props of express wrapped functions accessible Cleanup Preserve original handler name for Ghost Improve test Replace ULID Add test with operation name Add more tests Don't discover GraphQL queries from server-side rendering Fix tests (use createTestAgent utility fn) Fix lint Update comment Update comment ...
hansott
reviewed
Nov 26, 2024
library/agent/Agent.ts
Outdated
| @@ -341,6 +365,7 @@ export class Agent { | |||
| lastUpdatedAt: this.serviceConfig.getLastUpdatedAt(), | |||
| onConfigUpdate: (config) => { | |||
| this.updateServiceConfig({ success: true, ...config }); | |||
| this.updateBlockedIPAddresses().catch(() => {}); | |||
There was a problem hiding this comment.
let's not swallow but log?
| return undefined; | ||
| } | ||
|
|
||
| export function addIPAddressToBlocklist( |
| import { escapeHTML } from "../../helpers/escapeHTML"; | ||
| import { ipAllowedToAccessRoute } from "./ipAllowedToAccessRoute"; | ||
|
|
||
| export function checkIfIPAddressIsBlocked(res: ServerResponse, agent: Agent) { |
There was a problem hiding this comment.
let's state all kinds of checks performed by this function (it's goal) in comments
- eg route based
- geo/range list based
| "Accept-Encoding": "gzip", | ||
| Authorization: token.asString(), | ||
| }, | ||
| timeoutInMS: 10000, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.