Modify the fingerprinter not to use ConcurrentHashMap.computeIfAbsent…

…() because we cannot guarantee that the cache is not reentered by the computation.
AkaSkyKnight · Aug 23, 2019 · 99074b5 · 99074b5
1 parent a5d5e0d
commit 99074b5
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/...tion/src/main/kotlin/net/corda/serialization/internal/model/TypeModellingFingerPrinter.kt b/...tion/src/main/kotlin/net/corda/serialization/internal/model/TypeModellingFingerPrinter.kt
@@ -36,11 +36,15 @@ class TypeModellingFingerPrinter(
     private val cache: MutableMap<TypeIdentifier, String> = DefaultCacheProvider.createCache()
 
     override fun fingerprint(typeInformation: LocalTypeInformation): String =
-            cache.computeIfAbsent(typeInformation.typeIdentifier) {
-                FingerPrintingState(
-                        customTypeDescriptorLookup,
-                        FingerprintWriter(debugEnabled)).fingerprint(typeInformation)
-            }
+        /*
+         * We cannot use ConcurrentMap.computeIfAbsent() here because it requires
+         * that the map not be re-entered during the computation function. And
+         * the Fingerprinter cannot guarantee that.
+         */
+        cache.getOrPut(typeInformation.typeIdentifier) {
+            FingerPrintingState(customTypeDescriptorLookup, FingerprintWriter(debugEnabled))
+                    .fingerprint(typeInformation)
+        }
 }
 
 /**