Add limit to collection engine (laravel#569)

Alanaktion · Jan 7, 2022 · 0716725 · 0716725
1 parent ff1de46
commit 0716725
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Engines/CollectionEngine.php b/src/Engines/CollectionEngine.php
@@ -50,7 +50,7 @@ public function delete($models)
      */
     public function search(Builder $builder)
     {
-        $models = $this->searchModels($builder);
+        $models = $this->searchModels($builder)->take($builder->limit);
 
         return [
             'results' => $models->all(),

diff --git a/tests/Feature/CollectionEngineTest.php b/tests/Feature/CollectionEngineTest.php
@@ -102,4 +102,13 @@ public function test_it_can_paginate_results()
         $models = SearchableUserModel::search('laravel')->paginate();
         $this->assertCount(2, $models);
     }
+
+    public function test_limit_is_applied()
+    {
+        $models = SearchableUserModel::search('laravel')->get();
+        $this->assertCount(2, $models);
+
+        $models = SearchableUserModel::search('laravel')->take(1)->get();
+        $this->assertCount(1, $models);
+    }
 }