Skip to content

Commit

Permalink
tst_qprocess: enable test again for cross-compilations
Browse files Browse the repository at this point in the history
All test cases pass with QEMU.

Fixes: QTBUG-85287
Fixes: QTBUG-67760
Pick-to: 6.1
Change-Id: I188d70c05f6d858e17f1099d3c02862ea9b2a2ab
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Joerg Bornemann <[email protected]>
Reviewed-by: Edward Welbourne <[email protected]>
  • Loading branch information
sapiippo committed Feb 16, 2021
1 parent 5481601 commit 71eef47
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
7 changes: 1 addition & 6 deletions tests/auto/corelib/io/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,7 @@ if(TARGET Qt::Network)
add_subdirectory(qiodevice)
endif()
if(QT_FEATURE_process AND TARGET Qt::Network AND NOT ANDROID)
# special case begin
# QTBUG-85287: Hangs on qemu armv7 config
if(NOT CMAKE_CROSSCOMPILING)
add_subdirectory(qprocess)
endif()
# special case end
add_subdirectory(qprocess)
endif()
if(QT_FEATURE_process)
add_subdirectory(qprocess-noapplication)
Expand Down
1 change: 0 additions & 1 deletion tests/auto/corelib/io/qprocess/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ qt_internal_add_test(tst_qprocess
PUBLIC_LIBRARIES
Qt::CorePrivate
Qt::Network
Qt::TestPrivate
)

#### Keys ignored in scope 1:.:.:test.pro:<TRUE>:
Expand Down
3 changes: 0 additions & 3 deletions tests/auto/corelib/io/qprocess/tst_qprocess.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#include <QTest>
#include <QTestEventLoop>
#include <QSignalSpy>
#include <QtTest/private/qemulationdetector_p.h>

#include <QtCore/QProcess>
#include <QtCore/QDir>
Expand Down Expand Up @@ -1236,8 +1235,6 @@ void tst_QProcess::processInAThread()

void tst_QProcess::processesInMultipleThreads()
{
if (QTestPrivate::isRunningArmOnX86())
QSKIP("Flakily hangs in QEMU. QTBUG-67760");
for (int i = 0; i < 10; ++i) {
// run from 1 to 10 threads, but run at least some tests
// with more threads than the ideal
Expand Down

0 comments on commit 71eef47

Please sign in to comment.