Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off equations and constants given in lecture 4 of Solving PDEs on GPUs, this simulation is currently based off exercise 1, where the pressure update is done implicitly and the temperature done explicitly.
I've switched the use of the pseudo-transient method they use for a Poisson equation solve in order to retrieve the pressure based off temperature, such that the computed Darcy velocity is divergence-free (eqs 10 and 11 combined). This is I believe similar to what is being done in our vortices example.
More work currently needs to be done on the advection of the temperature as a result of the Darcy velocity since the velocity field is not constant over the space, as in the introductory advection-diffusion example , and the current Lie derivative scheme is not stable.