Hacks for displaying errors on failed scorings.

AlicTsai · May 9, 2014 · a6c62be · a6c62be
1 parent 2a87ef3
commit a6c62be
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 10 deletions.
diff --git a/client/src/scripts/h2o-proxy.coffee b/client/src/scripts/h2o-proxy.coffee
@@ -13,7 +13,10 @@ Steam.H2OProxy = (_) ->
         #TODO error logging / retries, etc.
         go error, result
       else
-        go error, result.data
+        if result.data.response.status is 'error'
+          go result.data.error, result.data
+        else
+          go error, result.data
 
 
   filterOutUnhandledModels = (models) -> filter models, (model) -> model.state is 'DONE' and model.model_category is 'Binomial'

diff --git a/client/src/scripts/scoring-list-view.coffee b/client/src/scripts/scoring-list-view.coffee
@@ -35,7 +35,7 @@ Steam.ScoringListView = (_) ->
       data:
         input: scoring
         output: null
-      title: scoring.frameKey
+      title: "Scoring on #{scoring.frameKey}"
       caption: "#{scoring.model.model_algorithm} (#{scoring.model.response_column_name})"
       timestamp: scoring.timestamp
       display: -> activateAndDisplayItem self
@@ -89,7 +89,7 @@ Steam.ScoringListView = (_) ->
             #item.time if error.response then error.response.time else 0
             item.state 'error'
             item.hasFailed yes
-            item.data.output = error
+            item.data.output = result
           else
             #TODO what does it mean to have > 1 metrics
             #TODO put this in the comparison table
@@ -112,7 +112,8 @@ Steam.ScoringListView = (_) ->
         jobs = createScoringJobs items
         runScoringJobs jobs, ->
           for item in items
-            item.timestamp = (head item.data.output.metrics).scoring_time
+            unless item.hasFailed()
+              item.timestamp = (head item.data.output.metrics).scoring_time
         activateAndDisplayItem head items
         _.scoringsLoaded()
       when 'comparison'

diff --git a/client/src/scripts/scoring-view.coffee b/client/src/scripts/scoring-view.coffee
@@ -3,8 +3,9 @@ Steam.ScoringView = (_, _scoring) ->
   _caption = node$ ''
   _timestamp = node$ Date.now()
   _comparisonTable = node$ null
-  _hasComparisonTable = lift$ _comparisonTable, (table) -> not isNull table
   _modelSummary = nodes$ []
+  _hasFailed = node$ no
+  _failure = node$ null
 
   createModelSummary = (model) ->
     [
@@ -35,10 +36,13 @@ Steam.ScoringView = (_, _scoring) ->
         _caption "Scoring on #{input.frameKey}"
         _modelSummary createModelSummary input.model
         apply$ scoring.isReady, scoring.hasFailed, (isReady, hasFailed) ->
-          if isReady and not hasFailed
-            #TODO untested
-            _timestamp (head scoring.data.output.metrics).scoring_time
-            displayComparisonTable [ scoring ]
+          if isReady
+            if hasFailed
+              _hasFailed yes
+              _failure scoring.data.output
+            else
+              _timestamp (head scoring.data.output.metrics).scoring_time
+              displayComparisonTable [ scoring ]
       when 'comparison'
         comparison = item
         _tag 'Comparison'
@@ -303,5 +307,6 @@ Steam.ScoringView = (_, _scoring) ->
   timestamp: _timestamp
   modelSummary: _modelSummary
   comparisonTable: _comparisonTable
-  hasComparisonTable: _hasComparisonTable
+  hasFailed: _hasFailed
+  failure: _failure
   template: 'scoring-view'
diff --git a/client/src/templates/scoring-view.jade b/client/src/templates/scoring-view.jade
@@ -14,4 +14,12 @@
         .y-summary-value(data-bind='text:value')
       // /ko
   // /ko
+
+  // ko ifnot:hasFailed
   div(data-bind='geyser:comparisonTable')
+  // /ko
+
+  // ko if:hasFailed
+  h2.y-subtitle Scoring Failure
+  pre(data-bind='json:failure')
+  // /ko