Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Commit

Permalink
Manually tweak minSdkVersion in lieu of using template from RN master (
Browse files Browse the repository at this point in the history
…facebook#312)

Summary:
Due to a recent change in minSdk requirements, RN master is no longer compatible with the RN stable template project.

Unfortunately the `--template` switch for `npx react-native` currently ignores the template, so we can't easily use the latest version.

This diff makes the required changes to the latest stable template instead.

Pull Request resolved: facebook#312

Test Plan: See if the test-e2e circleCI test works again

Reviewed By: dulinriley

Differential Revision: D22879255

Pulled By: willholen

fbshipit-source-id: 6b02f0fc4e39598f5b6ae0c1f1a25f98ba7d9928
  • Loading branch information
willholen authored and facebook-github-bot committed Aug 1, 2020
1 parent 80a63f6 commit 8dd548a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions test/circleci-e2e/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@ fi
( cd "$project_path" && git init && git add . )
commit "Initial project"

# The template project from RN 0.63 is no longer compatible with RN master. We
# should really be using the RN master template, but the CLI functionality for
# this is currently broken. Meanwhile, we'll just kludge the required changes.
#
# https://github.com/react-native-community/cli/pull/1110
#
sed_op 's/minSdkVersion = .*/minSdkVersion = 19/' "$project_dir"/android/build.gradle
commit "Kludge minSdkVersion until we can use an updated RN project"

# Enable Hermes
# https://reactnative.dev/docs/hermes
sed_op 's/enableHermes: false/enableHermes: true/' "$project_dir"/android/app/build.gradle
Expand Down

0 comments on commit 8dd548a

Please sign in to comment.