Merge pull request Alluxio#5066 from dreamgazer/lsqbranch

[ALLUXIO-2591] Fix logging style in BaseFileSystem
AllenChenGH · Apr 6, 2017 · f579732 · f579732
2 parents 71ab52e + 531833e
commit f579732
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/core/client/src/main/java/alluxio/client/file/BaseFileSystem.java b/core/client/src/main/java/alluxio/client/file/BaseFileSystem.java
@@ -85,7 +85,7 @@ public void createDirectory(AlluxioURI path, CreateDirectoryOptions options)
     FileSystemMasterClient masterClient = mFileSystemContext.acquireMasterClient();
     try {
       masterClient.createDirectory(path, options);
-      LOG.debug("Created directory " + path.getPath());
+      LOG.debug("Created directory {}, options: {}", path.getPath(), options);
     } finally {
       mFileSystemContext.releaseMasterClient(masterClient);
     }
@@ -105,7 +105,7 @@ public FileOutStream createFile(AlluxioURI path, CreateFileOptions options)
     try {
       masterClient.createFile(path, options);
       status = masterClient.getStatus(path);
-      LOG.debug("Created file " + path.getPath());
+      LOG.debug("Created file {}, options: {}", path.getPath(), options);
     } finally {
       mFileSystemContext.releaseMasterClient(masterClient);
     }
@@ -126,7 +126,7 @@ public void delete(AlluxioURI path, DeleteOptions options)
     FileSystemMasterClient masterClient = mFileSystemContext.acquireMasterClient();
     try {
       masterClient.delete(path, options);
-      LOG.debug("Deleted file " + path.getName());
+      LOG.debug("Deleted {}, options: {}", path.getPath(), options);
     } finally {
       mFileSystemContext.releaseMasterClient(masterClient);
     }
@@ -165,7 +165,7 @@ public void free(AlluxioURI path, FreeOptions options)
     FileSystemMasterClient masterClient = mFileSystemContext.acquireMasterClient();
     try {
       masterClient.free(path, options);
-      LOG.debug("Freed file " + path.getPath());
+      LOG.debug("Freed {}, options: {}", path.getPath(), options);
     } finally {
       mFileSystemContext.releaseMasterClient(masterClient);
     }
@@ -234,7 +234,7 @@ public void loadMetadata(AlluxioURI path, LoadMetadataOptions options)
     FileSystemMasterClient masterClient = mFileSystemContext.acquireMasterClient();
     try {
       masterClient.loadMetadata(path, options);
-      LOG.debug("loaded metadata {} with options {}", path.getParent(), options);
+      LOG.debug("Loaded metadata {}, options: {}", path.getPath(), options);
     } finally {
       mFileSystemContext.releaseMasterClient(masterClient);
     }
@@ -290,7 +290,7 @@ public void rename(AlluxioURI src, AlluxioURI dst, RenameOptions options)
     try {
       // TODO(calvin): Update this code on the master side.
       masterClient.rename(src, dst);
-      LOG.debug("Renamed file " + src.getPath() + " to " + dst.getPath());
+      LOG.debug("Renamed {} to {}, options: {}", src.getPath(), dst.getPath(), options);
     } finally {
       mFileSystemContext.releaseMasterClient(masterClient);
     }
@@ -308,7 +308,7 @@ public void setAttribute(AlluxioURI path, SetAttributeOptions options)
     FileSystemMasterClient masterClient = mFileSystemContext.acquireMasterClient();
     try {
       masterClient.setAttribute(path, options);
-      LOG.debug("Set attributes for path {} with options {}", path.getPath(), options);
+      LOG.debug("Set attributes for {}, options: {}", path.getPath(), options);
     } finally {
       mFileSystemContext.releaseMasterClient(masterClient);
     }
@@ -325,7 +325,7 @@ public void unmount(AlluxioURI path, UnmountOptions options)
     FileSystemMasterClient masterClient = mFileSystemContext.acquireMasterClient();
     try {
       masterClient.unmount(path);
-      LOG.info("Unmount " + path);
+      LOG.debug("Unmounted {}, options: {}", path.getPath(), options);
     } finally {
       mFileSystemContext.releaseMasterClient(masterClient);
     }