Skip to content

Commit

Permalink
Replaced unicode 'comma and space' as single glyph with regular comma…
Browse files Browse the repository at this point in the history
… and space characters (apache#15461)

### Motivation

I found log lines like
```
INFO  org.apache.pulsar.broker.loadbalance.BundleSplitStrategy - The count of topics on the bundle benchmark/ns-85SYDFY/0x4c000000_0x50000000 is less than 2,skip split!
```

this is coming from 

```
log.info("The count of topics on the bundle {} is less than 2,skip split!", bundle);
```
where "," is a single unicode character.

### Modifications

replaced "," with regular comma and space, skipped text/files where it was next to hieroglyphs/other unicode characters.

### Verifying this change

- [ ] Make sure that the change passes the CI checks.

### Does this pull request potentially affect one of the following parts:

*If `yes` was chosen, please highlight the changes*

NO

  - Dependencies (does it add or upgrade a dependency): (yes / no)
  - The public API: (yes / no)
  - The schema: (yes / no / don't know)
  - The default values of configurations: (yes / no)
  - The wire protocol: (yes / no)
  - The rest endpoints: (yes / no)
  - The admin cli options: (yes / no)
  - Anything that affects deployment: (yes / no / don't know)

### Documentation

Check the box below or label this PR directly.

Need to update docs? 

- [ ] `doc-required` 
(Your PR needs to update docs and you will update later)
  
- [x] `no-need-doc` 
(Please explain why)
  
- [ ] `doc` 
(Your PR contains doc changes)

- [ ] `doc-added`
(Docs have been already added)
  • Loading branch information
dlg99 authored May 6, 2022
1 parent 4ea9a62 commit be3243b
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public Set<String> findBundlesToSplit(final LoadData loadData, final PulsarServi
final String bundle = entry.getKey();
final NamespaceBundleStats stats = entry.getValue();
if (stats.topics < 2) {
log.info("The count of topics on the bundle {} is less than 2skip split!", bundle);
log.info("The count of topics on the bundle {} is less than 2, skip split!", bundle);
continue;
}
double totalMessageRate = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ public void testTopicLevelInactivePolicyUpdateAndClean() throws Exception {
});
admin.topics().removeInactiveTopicPolicies(topic2);
// The cache has been updated, but the system-event may not be consumed yet
// so wait for topic-policies update event
// , so wait for topic-policies update event
Awaitility.await().untilAsserted(() -> {
InactiveTopicPolicies nsPolicies = ((PersistentTopic) pulsar.getBrokerService()
.getTopic(topic2, false).get().get()).getInactiveTopicPolicies();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ public void testReadCompactedFunction() throws Exception {
String jarFilePathUrl = getPulsarApiExamplesJar().toURI().toString();
admin.functions().createFunctionWithUrl(functionConfig, jarFilePathUrl);

// 5 Function should only read compacted valueso we will only receive compacted messages
// 5 Function should only read compacted value, so we will only receive compacted messages
Consumer<String> consumer = pulsarClient.newConsumer(Schema.STRING).topic(sinkTopic).subscriptionName("sink-sub").subscribe();
int count = 0;
while (true) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public void testReadCompactedSink() throws Exception {
String jarFilePathUrl = getPulsarIODataGeneratorNar().toURI().toString();
admin.sinks().createSinkWithUrl(sinkConfig, jarFilePathUrl);

// 5 Sink should only read compacted valueso we will only receive compacted messages
// 5 Sink should only read compacted value, so we will only receive compacted messages
Awaitility.await().ignoreExceptions().untilAsserted(() -> {
String prometheusMetrics = PulsarFunctionTestUtils.getPrometheusMetrics(pulsar.getListenPortHTTP().get());
Map<String, PulsarFunctionTestUtils.Metric> metrics = PulsarFunctionTestUtils.parseMetrics(prometheusMetrics);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2750,7 +2750,7 @@ CompletableFuture<Void> setDelayedDeliveryMessagesAsync(
CompletableFuture<InactiveTopicPolicies> getInactiveTopicPoliciesAsync(String namespace);

/**
* As same as setInactiveTopicPoliciesAsyncbut it is synchronous.
* As same as setInactiveTopicPoliciesAsync, but it is synchronous.
* @param namespace
* @param inactiveTopicPolicies
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ private Type parseJsonPrestoType(String fieldname, Schema schema) {
return createUnboundedVarcharType();
case NULL:
throw new UnsupportedOperationException(format(
"field '%s' NULL type code should not be reached "
"field '%s' NULL type code should not be reached , "
+ "please check the schema or report the bug.", fieldname));
case FIXED:
case BYTES:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ private TopicName extractTopicName(HttpServletRequest request) {
final NamespaceName namespace = isV2Format ? NamespaceName.get(parts.get(5), parts.get(6)) :
NamespaceName.get(parts.get(4), parts.get(5), parts.get(6));

// The topic name which contains slashes is also splitso it needs to be jointed
// The topic name which contains slashes is also split, so it needs to be jointed
int startPosition = 7;
boolean isConsumer = "consumer".equals(parts.get(2)) || "consumer".equals(parts.get(3));
int endPosition = isConsumer ? parts.size() - 1 : parts.size();
Expand Down
2 changes: 1 addition & 1 deletion site2/docs/client-libraries-cpp.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ The `libpulsarwithdeps.a` does not include library openssl related libraries `li
$ rpm -ivh apache-pulsar-client*.rpm
```

After you install RPM successfully, Pulsar libraries are in the `/usr/lib` directoryfor example:
After you install RPM successfully, Pulsar libraries are in the `/usr/lib` directory, for example:
```bash
lrwxrwxrwx 1 root root 18 Dec 30 22:21 libpulsar.so -> libpulsar.so.2.9.1
lrwxrwxrwx 1 root root 23 Dec 30 22:21 libpulsarnossl.so -> libpulsarnossl.so.2.9.1
Expand Down
2 changes: 1 addition & 1 deletion site2/website/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ It also includes fixes for some breaking changes introduced in 2.9.0.
- Cancel scheduled tasks when deleting ManagedLedgerImpl [#12565](https://github.com/apache/pulsar/pull/12565)
- Add git branch information for PulsarVersion [#12541](https://github.com/apache/pulsar/pull/12541)
- Websocket should pass the encryption context to consumers [#12539](https://github.com/apache/pulsar/pull/12539)
- The count of topics on the bundle is less than 2skip split [#12527](https://github.com/apache/pulsar/pull/12527)
- The count of topics on the bundle is less than 2, skip split [#12527](https://github.com/apache/pulsar/pull/12527)
- Fix the reader skips compacted data which original ledger been removed [#12522](https://github.com/apache/pulsar/pull/12522)
- Fix `messageDedup` delete inactive producer name [#12493](https://github.com/apache/pulsar/pull/12493)
- Optimize the code: remove extra spaces [#12470](https://github.com/apache/pulsar/pull/12470)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ The `libpulsarwithdeps.a` does not include library openssl related libraries `li
$ rpm -ivh apache-pulsar-client*.rpm
```

After you install RPM successfully, Pulsar libraries are in the `/usr/lib` directoryfor example:
After you install RPM successfully, Pulsar libraries are in the `/usr/lib` directory, for example:
```bash
lrwxrwxrwx 1 root root 18 Dec 30 22:21 libpulsar.so -> libpulsar.so.2.9.1
lrwxrwxrwx 1 root root 23 Dec 30 22:21 libpulsarnossl.so -> libpulsarnossl.so.2.9.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
public class JdbcPostgresSinkTester extends SinkTester<PostgreSQLContainer> {

/**
* A Simple class to test jdbc class
* A Simple class to test jdbc class,
*/
@Data
public static class Foo {
Expand Down

0 comments on commit be3243b

Please sign in to comment.