improvement(zone): Update error message

Add zone name to the ZONE_CONLICT error message Signed-off-by: Arko Dasgupta <[email protected]>
Ameralhiti · Dec 21, 2020 · d7dfce0 · d7dfce0
1 parent 526deb5
commit d7dfce0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/firewall/core/fw_zone.py b/src/firewall/core/fw_zone.py
@@ -441,9 +441,11 @@ def add_interface(self, zone, interface, sender=None,
             raise FirewallError(errors.ZONE_ALREADY_SET,
                                 "'%s' already bound to '%s'" % (interface,
                                                                 zone))
-        if self.get_zone_of_interface(interface) is not None:
+        zoi = self.get_zone_of_interface(interface)
+        if zoi is not None:
             raise FirewallError(errors.ZONE_CONFLICT,
-                                "'%s' already bound to a zone" % interface)
+                                "'%s' already bound to '%s'" % (interface,
+                                                                 zoi))
 
         log.debug1("Setting zone of interface '%s' to '%s'" % (interface,
                                                                _zone))