Add OpenGL ES version to device properties.

AmesianX · Dec 18, 2017 · 2af554e · 2af554e
1 parent 2dac3d1
commit 2af554e
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 0 deletions.
diff --git a/lib/db/api.js b/lib/db/api.js
@@ -323,6 +323,7 @@ dbapi.saveDeviceIdentity = function(serial, identity) {
   , phone: identity.phone
   , product: identity.product
   , cpuPlatform: identity.cpuPlatform
+  , openGLESVersion: identity.openGLESVersion
   }))
 }
 

diff --git a/lib/units/device/plugins/solo.js b/lib/units/device/plugins/solo.js
@@ -43,6 +43,7 @@ module.exports = syrup.serial()
         , new wire.DevicePhoneMessage(identity.phone)
         , identity.product
         , identity.cpuPlatform
+        , identity.openGLESVersion
         ))
       ])
     })

diff --git a/lib/util/devutil.js b/lib/util/devutil.js
@@ -108,6 +108,17 @@ devutil.makeIdentity = function(serial, properties) {
   var abi = properties['ro.product.cpu.abi']
   var product = properties['ro.product.name']
   var cpuPlatform = properties['ro.board.platform']
+  var openGLESVersion = properties['ro.opengles.version']
+
+  openGLESVersion = parseInt(openGLESVersion, 10)
+  if (isNaN(openGLESVersion)) {
+    openGLESVersion = '0.0'
+  }
+  else {
+    var openGLESVersionMajor = (openGLESVersion & 0xffff0000) >> 16
+    var openGLESVersionMinor = (openGLESVersion & 0xffff)
+    openGLESVersion = openGLESVersionMajor + '.' + openGLESVersionMinor
+  }
 
   // Remove brand prefix for consistency
   if (model.substr(0, brand.length) === brand) {
@@ -132,5 +143,6 @@ devutil.makeIdentity = function(serial, properties) {
   , sdk: sdk
   , product: product
   , cpuPlatform: cpuPlatform
+  , openGLESVersion: openGLESVersion
   }
 }
diff --git a/lib/wire/wire.proto b/lib/wire/wire.proto
@@ -227,6 +227,7 @@ message DeviceIdentityMessage {
   required DevicePhoneMessage phone = 11;
   optional string product = 12;
   optional string cpuPlatform = 13;
+  optional string openGLESVersion = 14;
 }
 
 message DeviceProperty {

diff --git a/res/app/device-list/column/device-column-service.js b/res/app/device-list/column/device-column-service.js
@@ -201,6 +201,12 @@ module.exports = function DeviceColumnService($filter, gettext) {
         return device.cpuPlatform || ''
       }
     })
+  , openGLESVersion: TextCell({
+      title: gettext('OpenGL ES version')
+    , value: function(device) {
+        return device.openGLESVersion || ''
+      }
+    })
   , phone: TextCell({
       title: gettext('Phone')
     , value: function(device) {

diff --git a/res/app/device-list/device-list-controller.js b/res/app/device-list/device-list-controller.js
@@ -67,6 +67,10 @@ module.exports = function DeviceListCtrl(
       name: 'cpuPlatform'
     , selected: false
     }
+  , {
+      name: 'openGLESVersion'
+    , selected: false
+    }
   , {
       name: 'browser'
     , selected: false