Skip to content

Commit

Permalink
Some bug fixes and improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
AminBhst committed Oct 28, 2024
1 parent 2d5b92a commit 66bfe7f
Show file tree
Hide file tree
Showing 8 changed files with 1,016 additions and 890 deletions.
15 changes: 12 additions & 3 deletions app/manifest.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
{
"name": "Brisk",
"description": "Browser extension for Brisk download manager",
"version": "1.1.2",
"short_name": "Brisk",
"description": "Browser extension for Brisk download manager",
"version": "1.1.3",
"__firefox__browser_specific_settings": {
"gecko": {
"id": "{9ca5a4a8-58d1-4a47-8e0d-5e53a21c9a7b}"
}
},
"manifest_version": 3,
"homepage_url": "https://github.com/AminBhst/brisk-browser-extension",
"background": {
Expand All @@ -18,6 +23,11 @@
]
}
],
"__firefox__background": {
"scripts": [
"scripts/background.js"
]
},
"content_security_policy": {
"extension_pages": "script-src 'self'; object-src 'self'"
},
Expand All @@ -34,7 +44,6 @@
"icons": {
"16": "images/logo16.png",
"32": "images/logo32.png",
"48": "images/logo48.png",
"128": "images/logo128.png"
},
"web_accessible_resources": [
Expand Down
4 changes: 2 additions & 2 deletions app/pages/popup.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<html>
<!DOCTYPE HTML>


<head>
Expand All @@ -11,7 +11,7 @@
<body>
<div class="row">
<div class="col-md-12">
<img src="../images/logo.png" alt="Brisk">
<img src="../images/logo128.png" alt="Brisk">
<label for="port">Port:</label>
<input type="number" id="port" name="port">
<button id="save" type="submit">Save</button>
Expand Down
17 changes: 11 additions & 6 deletions app/scripts/background.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ import {sendRequestToBrisk} from "./common";

let downloadHrefs;
createContextMenuItem();
browser.runtime.onInstalled.addListener(() => {
browser.storage.sync.set({briskPort: 3020});
});
browser.downloads.onCreated.addListener(sendBriskDownloadAdditionRequest);

browser.runtime.onMessage.addListener((message) => downloadHrefs = message);

browser.contextMenus.onClicked.addListener(async (info, tab) => {
Expand Down Expand Up @@ -45,11 +47,14 @@ async function removeBrowserDownload(id) {
}

function createContextMenuItem() {
browser.contextMenus.create({
id: "brisk-download",
title: "Download selected links with Brisk",
contexts: ["selection"]
}, () => null);
browser.contextMenus.removeAll().then(() => {
browser.contextMenus.create({
id: "brisk-download",
title: "Download selected links with Brisk",
contexts: ["selection"]
}, () => null);
}
).catch(console.log);
}

const pass = () => null;
2 changes: 2 additions & 0 deletions app/scripts/common.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as browser from "webextension-polyfill";

export const defaultPort = 3020;
const extensionVersion = browser.runtime.getManifest().version;

async function getBriskBaseUrl() {
return "http://localhost:" + await getBriskPort();
Expand All @@ -12,6 +13,7 @@ export async function sendRequestToBrisk(body) {
// return;

// lastRequestSent = Date.now();
body.extensionVersion = extensionVersion;
return await fetch(
await getBriskBaseUrl(),
{method: 'POST', body: JSON.stringify(body)}
Expand Down
14 changes: 10 additions & 4 deletions app/scripts/config.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import * as browser from 'webextension-polyfill';


await setPortValue();
setSaveButtonAction();
document.addEventListener('DOMContentLoaded', async () => {
await setPortValue();
setSaveButtonAction();
});

async function onSaveClicked() {
let port = document.getElementById("port").value;
Expand All @@ -18,6 +20,10 @@ function setSaveButtonAction() {
}

async function setPortValue() {
let val = await browser.storage.sync.get(['briskPort']);
document.getElementById("port").value = val['briskPort'];
try {
let val = await browser.storage.sync.get(['briskPort']);
document.getElementById("port").value = val['briskPort'];
} catch (e) {
console.log(e);
}
}
8 changes: 6 additions & 2 deletions app/scripts/content-script.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ function debounce(fn, delay) {
}

document.addEventListener("selectionchange", debounce(function (event) {
let extractedHrefs = getHrefOfAllSelectedLinks();
sendHrefsToBackground(extractedHrefs);
try {
let extractedHrefs = getHrefOfAllSelectedLinks();
sendHrefsToBackground(extractedHrefs);
} catch (e) {
console.log(e);
}
}, 250));


Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "brisk-browser-extension",
"version": "1.0.0",
"version": "1.1.2",
"description": "WebExtension for Brisk download manager",
"scripts": {
"dev": "webextension-toolbox dev",
Expand Down
Loading

0 comments on commit 66bfe7f

Please sign in to comment.