Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
x86, kaslr: fix module lock ordering problem
There was a potential lock ordering problem with the module kASLR patch ("x86, kaslr: randomize module base load address"). This patch removes the usage of the module_mutex and creates a new mutex to protect the module base address offset value. Chain exists of: text_mutex --> kprobe_insn_slots.mutex --> module_mutex [ 0.515561] Possible unsafe locking scenario: [ 0.515561] [ 0.515561] CPU0 CPU1 [ 0.515561] ---- ---- [ 0.515561] lock(module_mutex); [ 0.515561] lock(kprobe_insn_slots.mutex); [ 0.515561] lock(module_mutex); [ 0.515561] lock(text_mutex); [ 0.515561] [ 0.515561] *** DEADLOCK *** Reported-by: Fengguang Wu <[email protected]> Signed-off-by: Andy Honig <[email protected]> Signed-off-by: Kees Cook <[email protected]> Reviewed-by: Masami Hiramatsu <[email protected]> Signed-off-by: H. Peter Anvin <[email protected]>
- Loading branch information