ofp-util: Avoid use-after-free error in ofputil_append_meter_config().

Reported-by: weizj <[email protected]> Reported-at: openvswitch#97 Signed-off-by: Ben Pfaff <[email protected]>
AndreMantas · Jan 5, 2016 · 32756a5 · 32756a5
1 parent 9d4e54c
commit 32756a5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -420,6 +420,7 @@ likunyun                [email protected]
 meishengxin             [email protected]
 neeraj mehta            [email protected]
 rahim entezari          [email protected]
+weizj                   [email protected]
 俊 赵                    [email protected]
 冯全树(Crab)            [email protected]
 胡靖飞                  [email protected]

diff --git a/lib/ofp-util.c b/lib/ofp-util.c
@@ -2039,6 +2039,7 @@ ofputil_append_meter_config(struct ovs_list *replies,
 
     ofputil_put_bands(mc->n_bands, mc->bands, msg);
 
+    reply = ofpbuf_at_assert(msg, start_ofs, sizeof *reply);
     reply->length = htons(msg->size - start_ofs);
 
     ofpmp_postappend(replies, start_ofs);