Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handlers.ipynb #644

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Update handlers.ipynb #644

merged 1 commit into from
Jan 30, 2025

Conversation

Isaac-Flath
Copy link
Contributor


name: Pull Request
about: Propose changes to the codebase
title: '[Bug fix handlers tutorial] '
labels: 'documentation'
assignees: '@Isaac-Flath'


Related Issue

#643

Proposed Changes

Re-initialize app and cli after the API router section so that requests are properly sent and received. I also added a few periodic tests so that it should cause a tests failure if this happens again

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

@Isaac-Flath Isaac-Flath added the documentation Improvements or additions to documentation label Jan 30, 2025
Copy link

gitnotebooks bot commented Jan 30, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/644

@Isaac-Flath Isaac-Flath requested a review from jph00 January 30, 2025 21:41
@jph00
Copy link
Contributor

jph00 commented Jan 30, 2025

Great! Thank you for the quick fix.

@jph00 jph00 merged commit 536f477 into main Jan 30, 2025
2 checks passed
@jph00 jph00 deleted the handlers-tutorial-fix branch January 30, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants