Skip to content

Commit

Permalink
arm64: PCI: Support root bridge preparation for Hyper-V
Browse files Browse the repository at this point in the history
Currently at root bridge preparation, the corresponding ACPI device will
be set as the companion, however for a Hyper-V virtual PCI root bridge,
there is no corresponding ACPI device, because a Hyper-V virtual PCI
root bridge is discovered via VMBus rather than ACPI table. In order to
support this, we need to make pcibios_root_bridge_prepare() work with
cfg->parent being NULL.

Use a NULL pointer as the ACPI device if there is no corresponding ACPI
device, and this is fine because: 1) ACPI_COMPANION_SET() can work with
the second parameter being NULL, 2) semantically, if a NULL pointer is
set via ACPI_COMPANION_SET(), ACPI_COMPANION() (the read API for this
field) will return NULL, and since ACPI_COMPANION() may return NULL, so
users must have handled the cases where it returns NULL, and 3) since
there is no corresponding ACPI device, it would be wrong to use any
other value here.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Boqun Feng <[email protected]>
Signed-off-by: Lorenzo Pieralisi <[email protected]>
Acked-by: Catalin Marinas <[email protected]>
  • Loading branch information
fbq authored and Lorenzo Pieralisi committed Aug 23, 2021
1 parent b424d4d commit 7d40c0f
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion arch/arm64/kernel/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,17 @@ int pcibios_root_bridge_prepare(struct pci_host_bridge *bridge)
return 0;

cfg = bridge->bus->sysdata;
adev = to_acpi_device(cfg->parent);

/*
* On Hyper-V there is no corresponding ACPI device for a root bridge,
* therefore ->parent is set as NULL by the driver. And set 'adev' as
* NULL in this case because there is no proper ACPI device.
*/
if (!cfg->parent)
adev = NULL;
else
adev = to_acpi_device(cfg->parent);

bus_dev = &bridge->bus->dev;

ACPI_COMPANION_SET(&bridge->dev, adev);
Expand Down

0 comments on commit 7d40c0f

Please sign in to comment.