LADX: correct in-game check counter #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palex00
approved these changes
Dec 13, 2024
Exempt-Medic
added
waiting-on: peer-review
ScipioWright
added
waiting-on: core-review
ScipioWright
approved these changes
Dec 13, 2024
Exempt-Medic
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The in-game check counter that displays at the end of the game isn't counting the mandatory first check (Tarin's Gift) and so it is off by one. This inflates the check count by one at the start to correct.
How was this tested?
It has been in the rolling ladx beta since Nov 14, waiting for a confirmation that it does what it is meant to do before undrafting.