Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LADX: fix for syntax warning #4376

Merged
merged 4 commits into from
Dec 20, 2024
Merged

LADX: fix for syntax warning #4376

merged 4 commits into from
Dec 20, 2024

Conversation

threeandthreee
Copy link
Contributor

What is this fixing or adding?

Use raw string to avoid a SyntaxWarning

https://docs.python.org/3/whatsnew/3.12.html#other-language-changes

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Dec 15, 2024
Jouramie
Jouramie approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@Jouramie Jouramie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a Python console, this does indeed remove the warning about \d being an invalid escape sequence.

LGTM

nicholassaylor
nicholassaylor approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Dec 19, 2024
@Exempt-Medic Exempt-Medic merged commit 35d3044 into ArchipelagoMW:main Dec 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@Jouramie Jouramie Jouramie approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@threeandthreee @Jouramie @Exempt-Medic @nicholassaylor