fix(Field): falsy values in contructor: fix alibaba-fusion#897

AricZhu · Jul 19, 2019 · 3d1743d · 3d1743d
1 parent 530896d
commit 3d1743d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/field/index.js b/src/field/index.js
@@ -107,8 +107,8 @@ class Field {
             defaultValue = originalProps[defaultValueName];
         } else if (parseName) {
             defaultValue = getIn(this.values, name);
-        } else {
-            defaultValue = (this.values && this.values[name]) || undefined;
+        } else if (this.values && typeof this.values[name] !== 'undefined') {
+            defaultValue = this.values[name];
         }
 
         Object.assign(field, {

diff --git a/test/field/options-spec.js b/test/field/options-spec.js
@@ -197,6 +197,17 @@ describe('options', () => {
             assert.equal(field.getValue('input'), inputValue);
         });
 
+        it('should set default field input values when given falsy `values` in constructor', function() {
+            const inputValue = 0;
+            const field = new Field(this, {
+                values: {
+                    input: inputValue
+                },
+            });
+            field.init('input');
+            assert.equal(field.getValue('input'), inputValue);
+        });
+
         it('should set default field input values when given `values` and `parseName` = true in constructor', function() {
             const inputValue = 'my value';
             const field = new Field(this, {