Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GET_TIP_FORMING and SET_TIP_FORMING #210

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

rschaeuble
Copy link
Contributor

@rschaeuble rschaeuble commented Dec 29, 2024

These commands allow to view and update the tip forming configuration at runtime.

Major Changes in this PR

Implement GET_TIP_FORMING and SET_TIP_FORMING, so that the tip forming configuration can be viewed and updated at runtime.

Notes to Code Reviewers

How the changes in this PR are tested

Manually

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@rschaeuble
Copy link
Contributor Author

I don't know why generate_docs.py made so many changes and why it doesn't pick of the correct usage documentation. I can undo the changes to that file is requested.

@ejsears
Copy link
Contributor

ejsears commented Dec 29, 2024

I don't know why generate_docs.py made so many changes and why it doesn't pick of the correct usage documentation. I can undo the changes to that file is requested.

It probably wasn't run on the last merge to main. I'm pretty sure it is case sensitive when it is looking for Usage vice USAGE in your code.

These commands allow to view and update the tip forming configuration
at runtime.
@rschaeuble
Copy link
Contributor Author

I changed USAGE to Usage and now the docs are good, too.

@rschaeuble
Copy link
Contributor Author

I can't send a notification to the software-design channel, though, as I don't see it in the channels list on Discord.

@MG-longshot MG-longshot merged commit 50e7545 into ArmoredTurtle:main Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants