re-implement Table.move with native table extension

ArturusRex · Apr 27, 2022 · 5829381 · 5829381
1 parent 6918d36
commit 5829381
Show file tree

Hide file tree

Showing 22 changed files with 747 additions and 788 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/api/goldens/aptos_api__tests__accounts_test__test_account_modules.json b/api/goldens/aptos_api__tests__accounts_test__test_account_modules.json
diff --git a/api/goldens/aptos_api__tests__accounts_test__test_account_modules_structs.json b/api/goldens/aptos_api__tests__accounts_test__test_account_modules_structs.json
diff --git a/api/goldens/aptos_api__tests__accounts_test__test_get_module_aptos_config.json b/api/goldens/aptos_api__tests__accounts_test__test_get_module_aptos_config.json
diff --git a/api/goldens/aptos_api__tests__accounts_test__test_get_module_with_script_functions.json b/api/goldens/aptos_api__tests__accounts_test__test_get_module_with_script_functions.json
diff --git a/...ptos_api__tests__transactions_test__test_get_transactions_output_genesis_transaction.json b/...ptos_api__tests__transactions_test__test_get_transactions_output_genesis_transaction.json
diff --git a/...ons_test__test_get_transactions_output_user_transaction_with_script_function_payload.json b/...ons_test__test_get_transactions_output_user_transaction_with_script_function_payload.json
@@ -3,12 +3,12 @@
     "type": "block_metadata_transaction",
     "version": "1",
     "hash": "0xa8fc186c28fc0f95b8233651438093e8e215a51dcd16475f5e68c0a421f6305c",
-    "state_root_hash": "0x9c89d31d92b19012cc8f74b695b4f4dd9137996c008a165154a17fa3f49ae9f4",
+    "state_root_hash": "0x8e8d033419b5d2c32c863069a7745dfa57ac8f5c420ea43b0e92621ae7b855c7",
     "event_root_hash": "0xd62c85b93234824cf825e9c028c3bcc59b06926039721bd7edd76b56ae9fcecf",
     "gas_used": "0",
     "success": true,
     "vm_status": "Executed successfully",
-    "accumulator_root_hash": "0x8df7dd26d31b0def0cbcc733d7d0cb28004aeaa5fe756172fa35945562a12086",
+    "accumulator_root_hash": "0xdcf615b5978b3273ec5e81298eab09fefb28542f26fb5d8791814d53f1f31095",
     "changes": [
       {
         "type": "write_resource",
@@ -56,12 +56,12 @@
     "type": "user_transaction",
     "version": "2",
     "hash": "0x18073cb2536317833aa630d30062383a1f00221dd3604bbce19cd262813e6c36",
-    "state_root_hash": "0xcf6ce5dc6f59e72c9afbcecbc388b0e97998de2b07d5f12f8f0ffdd05fc1a45c",
+    "state_root_hash": "0xbaf51db8bf5a5ee511928b03da8195306b126fbd66c1688ff7178ad28bab86d0",
     "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
     "gas_used": "92",
     "success": true,
     "vm_status": "Executed successfully",
-    "accumulator_root_hash": "0x130ed5d43b3aadc635b65790f9b65030f0ec324809bbc2608f8e4823cdcc2583",
+    "accumulator_root_hash": "0xeee833776348d0fa4e93ee9d2faa6a4f59e16bcbb12d1477a68dc0d1b66f47c1",
     "changes": [
       {
         "type": "write_resource",

diff --git a/...ns_test__test_get_transactions_returns_last_page_when_start_version_is_not_specified.json b/...ns_test__test_get_transactions_returns_last_page_when_start_version_is_not_specified.json
diff --git a/...s__transactions_test__test_get_txn_execute_failed_by_invalid_module_payload_bytecode.json b/...s__transactions_test__test_get_txn_execute_failed_by_invalid_module_payload_bytecode.json
@@ -2,12 +2,12 @@
   "type": "user_transaction",
   "version": "2",
   "hash": "0xf1d9819d9c3890f1d3e515be30cf920bd5bba8a7616dc02f21438c3ce08e27fa",
-  "state_root_hash": "0x4b11ccdf958617bbff0aaf8d16ebcfd4c09113c8c261557580e498e158d0ae0a",
+  "state_root_hash": "0x590f869a35bfa866f85baca8bd5fbab5c53f7911bc70c10d8bb29b0187d89b1d",
   "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
   "gas_used": "1",
   "success": false,
   "vm_status": "Move bytecode deserialization / verification failed, including script function not found or invalid arguments",
-  "accumulator_root_hash": "0x489d7a0c4e5f11d7f34ccfe5edc751b0694e0d7717a453825af561724b68e84a",
+  "accumulator_root_hash": "0x57fe684da8f5e4f43abff4fa0c92bee0bec2def71f630f73f21aec8fe7054132",
   "changes": [
     {
       "type": "write_resource",

diff --git a/...s__transactions_test__test_get_txn_execute_failed_by_invalid_script_function_address.json b/...s__transactions_test__test_get_txn_execute_failed_by_invalid_script_function_address.json
@@ -2,12 +2,12 @@
   "type": "user_transaction",
   "version": "2",
   "hash": "0x97053ab47cdf9d0bee6a38b61d4ca5366090474be9191c589377dad77b3fab66",
-  "state_root_hash": "0x4b11ccdf958617bbff0aaf8d16ebcfd4c09113c8c261557580e498e158d0ae0a",
+  "state_root_hash": "0x590f869a35bfa866f85baca8bd5fbab5c53f7911bc70c10d8bb29b0187d89b1d",
   "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
   "gas_used": "1",
   "success": false,
   "vm_status": "Move bytecode deserialization / verification failed, including script function not found or invalid arguments",
-  "accumulator_root_hash": "0x5aa3e595ad20edc730d46a20f20f5652101deb81f103b8e7a6070a3ab2e8e494",
+  "accumulator_root_hash": "0xf09a61fc18bfddecb3d0d0105b7dbd876e3a7c1604e6b2b83cb3cb9307d77f41",
   "changes": [
     {
       "type": "write_resource",

diff --git a/..._transactions_test__test_get_txn_execute_failed_by_invalid_script_function_arguments.json b/..._transactions_test__test_get_txn_execute_failed_by_invalid_script_function_arguments.json
@@ -2,12 +2,12 @@
   "type": "user_transaction",
   "version": "2",
   "hash": "0x0760cc0dfba7e747fdcfda4ffeffbe4fa42061482758e14803535f5babfb09a0",
-  "state_root_hash": "0x4b11ccdf958617bbff0aaf8d16ebcfd4c09113c8c261557580e498e158d0ae0a",
+  "state_root_hash": "0x590f869a35bfa866f85baca8bd5fbab5c53f7911bc70c10d8bb29b0187d89b1d",
   "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
   "gas_used": "1",
   "success": false,
   "vm_status": "Move bytecode deserialization / verification failed, including script function not found or invalid arguments",
-  "accumulator_root_hash": "0x97106d3b12522bccc3cf74856b46de41d0776e03d8ca8df82624f389eb0f1845",
+  "accumulator_root_hash": "0xa456557480024a581434c0f7ef73ab6ddbb8d4dbcc52b63619b4d491185ce01b",
   "changes": [
     {
       "type": "write_resource",

diff --git a/...ransactions_test__test_get_txn_execute_failed_by_invalid_script_function_module_name.json b/...ransactions_test__test_get_txn_execute_failed_by_invalid_script_function_module_name.json
@@ -2,12 +2,12 @@
   "type": "user_transaction",
   "version": "2",
   "hash": "0x454dcd76c7a06eebaf8674a72bb4ecd991b268047a6af9bba9fc15a8baa49af2",
-  "state_root_hash": "0x4b11ccdf958617bbff0aaf8d16ebcfd4c09113c8c261557580e498e158d0ae0a",
+  "state_root_hash": "0x590f869a35bfa866f85baca8bd5fbab5c53f7911bc70c10d8bb29b0187d89b1d",
   "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
   "gas_used": "1",
   "success": false,
   "vm_status": "Move bytecode deserialization / verification failed, including script function not found or invalid arguments",
-  "accumulator_root_hash": "0xfe5f1ac6c9ea7edc4042f743f5ab19c8383ab28694b1f3f47600d8bce672844d",
+  "accumulator_root_hash": "0x7d33b5341560c53443de5bed207cdfbf0aef92b26aa5bf9b443714d217f30cf8",
   "changes": [
     {
       "type": "write_resource",

diff --git a/...ests__transactions_test__test_get_txn_execute_failed_by_invalid_script_function_name.json b/...ests__transactions_test__test_get_txn_execute_failed_by_invalid_script_function_name.json
@@ -2,12 +2,12 @@
   "type": "user_transaction",
   "version": "2",
   "hash": "0xc00c694596b002f38c4a5eb5b8b20a772cb2bc7e5aacd3b2637e73bec802796e",
-  "state_root_hash": "0x4b11ccdf958617bbff0aaf8d16ebcfd4c09113c8c261557580e498e158d0ae0a",
+  "state_root_hash": "0x590f869a35bfa866f85baca8bd5fbab5c53f7911bc70c10d8bb29b0187d89b1d",
   "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
   "gas_used": "1",
   "success": false,
   "vm_status": "Move bytecode deserialization / verification failed, including script function not found or invalid arguments",
-  "accumulator_root_hash": "0x1cb8740fa54d343f571fad37c10b329a8e3fd0c9719dba3a35ed52adc5af2a4e",
+  "accumulator_root_hash": "0xd8f750b91d389cacc8a5c4cae3d1fd0a48a52919ff3b98845bdaf78b4ca353e6",
   "changes": [
     {
       "type": "write_resource",

diff --git a/...s__transactions_test__test_get_txn_execute_failed_by_invalid_script_payload_bytecode.json b/...s__transactions_test__test_get_txn_execute_failed_by_invalid_script_payload_bytecode.json
@@ -2,12 +2,12 @@
   "type": "user_transaction",
   "version": "2",
   "hash": "0xd99666ee3f06d5d564d1e8bf5955a020e7634fd9b539c2b6bab071670548f625",
-  "state_root_hash": "0x4b11ccdf958617bbff0aaf8d16ebcfd4c09113c8c261557580e498e158d0ae0a",
+  "state_root_hash": "0x590f869a35bfa866f85baca8bd5fbab5c53f7911bc70c10d8bb29b0187d89b1d",
   "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
   "gas_used": "1",
   "success": false,
   "vm_status": "Move bytecode deserialization / verification failed, including script function not found or invalid arguments",
-  "accumulator_root_hash": "0x44e4010e9ed6ff6d3d2b80731e3ed9102461bc85027acc4094bef6e336dbfff0",
+  "accumulator_root_hash": "0xd38ac0cb812f8fda728639cf6f1ba9262d074a533cdff884c681078af6a30aa1",
   "changes": [
     {
       "type": "write_resource",

diff --git a/..._transactions_test__test_get_txn_execute_failed_by_missing_script_function_arguments.json b/..._transactions_test__test_get_txn_execute_failed_by_missing_script_function_arguments.json
@@ -2,12 +2,12 @@
   "type": "user_transaction",
   "version": "2",
   "hash": "0x8df66affad9c571750829820259721f96af4d7ae787bd7089bea259ff0f82cb1",
-  "state_root_hash": "0x4b11ccdf958617bbff0aaf8d16ebcfd4c09113c8c261557580e498e158d0ae0a",
+  "state_root_hash": "0x590f869a35bfa866f85baca8bd5fbab5c53f7911bc70c10d8bb29b0187d89b1d",
   "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
   "gas_used": "1",
   "success": false,
   "vm_status": "Move bytecode deserialization / verification failed, including script function not found or invalid arguments",
-  "accumulator_root_hash": "0x82753b92ed78e200ed4baaecf2e0817af38387a52e48d248ea0e56383a6f88fa",
+  "accumulator_root_hash": "0xa12a2b366862a15ce0585e6fc469434544a0040232a74bcbe6a0a568988364de",
   "changes": [
     {
       "type": "write_resource",

diff --git a/..._tests__transactions_test__test_get_txn_execute_failed_by_script_function_validation.json b/..._tests__transactions_test__test_get_txn_execute_failed_by_script_function_validation.json
@@ -2,12 +2,12 @@
   "type": "user_transaction",
   "version": "4",
   "hash": "0x67d3d83ebf873c54ae08380b8984ee3bef0227c284117384b9e086498c52fb90",
-  "state_root_hash": "0x94bd5d584ae73e5e2fe7692969d05cd2dec34f6da8ba30288d7cf091a423f123",
+  "state_root_hash": "0xe816b0798c46b716b29a16be84d632df2fe1075be051eab29cf2e7bcfe748853",
   "event_root_hash": "0x414343554d554c41544f525f504c414345484f4c4445525f4841534800000000",
   "gas_used": "21",
   "success": false,
   "vm_status": "Move abort by LIMIT_EXCEEDED - EINSUFFICIENT_BALANCE\n A limit on an amount, e.g. a currency, is exceeded. Example: withdrawal of money after account limits window\n is exhausted.\n Error codes",
-  "accumulator_root_hash": "0x2bbf4871e1c9d6b9fb037bffabf94849df5058ccc76f2bae7755da8ffe6f1fc6",
+  "accumulator_root_hash": "0xd1ae15e5fcef7264c30ddb0777f8d0821b35106b7a54316d3b9b1a34b4a0516e",
   "changes": [
     {
       "type": "write_resource",

diff --git a/aptos-move/framework/Cargo.toml b/aptos-move/framework/Cargo.toml
@@ -44,10 +44,11 @@ tempfile = "3.2.0"
 
 [dev-dependencies]
 datatest-stable = "0.1.1"
+dir-diff = "0.3.2"
+
 aptos-vm = { path = "../../aptos-move/aptos-vm" }
 move-cli = { git = "https://github.com/move-language/move", rev = "1b6b7513dcc1a5c866f178ca5c1e74beb2ce181e" }
-move-unit-test = { git = "https://github.com/move-language/move", rev = "1b6b7513dcc1a5c866f178ca5c1e74beb2ce181e" }
-dir-diff = "0.3.2"
+move-unit-test = { git = "https://github.com/move-language/move", rev = "1b6b7513dcc1a5c866f178ca5c1e74beb2ce181e", features=["table-extension"] }
 
 [features]
 default = []