Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #130 Empty response for NOT_MODIFIED #131

Merged
merged 4 commits into from
Jun 20, 2018
Merged

fix #130 Empty response for NOT_MODIFIED #131

merged 4 commits into from
Jun 20, 2018

Conversation

ricardojlrufino
Copy link
Contributor

@ricardojlrufino ricardojlrufino commented Jun 10, 2018 •
edited
Loading

2b0f1b1 fix and revert changes in 6b428a7

@ricardojlrufino
Copy link
Contributor Author

@jfarcand
this is necessary every time ?
ctx.pipeline().addBefore(BridgeRuntime.class.getName(), "encoder", new HttpResponseEncoder());

@ricardojlrufino ricardojlrufino mentioned this pull request Jun 10, 2018
Closed
@jfarcand
Copy link
Member

@ricardojlrufino Yes it is unless it was added by default. If you remove it, does it still work?

@ricardojlrufino
Copy link
Contributor Author

@jfarcand not work, i need it move to upper , to fiz bug in sendNotModified

@jfarcand
Copy link
Member

@ricardojlrufino Patch looks good, but can you add a unit test? Thanks a lot!

@ricardojlrufino
Copy link
Contributor Author

Sorry but I have no idea how to implement for this specific use case

@jfarcand
Copy link
Member

@ricardojlrufino How do you test it?

@ricardojlrufino
Copy link
Contributor Author

ricardojlrufino commented Jun 13, 2018 •
edited
Loading

I am implementing the protocol of this equipment: SonOff
(THIS IS THE PING PROBLEM)
image

@ricardojlrufino
Copy link
Contributor Author

ricardojlrufino commented Jun 13, 2018 •
edited
Loading

(THE CACHE PROBLEM)
I'm testing directly in chrome, I WAIT it does the cache .... and then it starts to appear these errors of EMPTY_RESPONSE

jfarcand
jfarcand reviewed Jun 15, 2018
View reviewed changes
server/src/main/java/org/atmosphere/nettosphere/HttpStaticFileServerHandler.java Outdated
import static io.netty.handler.codec.http.HttpHeaders.Names.CONTENT_TYPE;
import static io.netty.handler.codec.http.HttpHeaders.Names.IF_MODIFIED_SINCE;
import static io.netty.handler.codec.http.HttpHeaders.Names.LOCATION;
import static io.netty.handler.codec.http.HttpHeaders.Names.*;
import static io.netty.handler.codec.http.HttpMethod.GET;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the import

@jfarcand
Copy link
Member

@ricardojlrufino OK fair enough. Can you just fix the comment and I will integrate your fix and cut a release ASAP. Thanks!

@jfarcand jfarcand merged commit cd57725 into Atmosphere:master Jun 20, 2018
@jfarcand jfarcand added this to the 3.0.5 milestone Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfarcand jfarcand jfarcand left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardojlrufino @jfarcand