Remove unused lane that duplicated existing one #641
Merged
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
commented
Jan 20, 2025
Comment on lines
-130
to
-132
| lane :configure_code_signing_prototype_build do |readonly: true| | ||
| configure_code_signing(bundle_ids: [bundle_id_prototype_build!], readonly: readonly) | ||
| end |
There was a problem hiding this comment.
This was exactly the same call as :configure_code_signing above.
There was a problem hiding this comment.
Nice find. I'll just give it a 👍 here, since someone from your team should review (as you requested).
|
 |
App Name |  Gravatar Prototype Build |
| Build Number | 2025 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | bbe95ce | |
| App Center Build | Gravatar SDK Demo - UIKit #555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I landed here while regenerating the Enterprise provisioning profiles after creating a new distribution certificate. Internal reference pdnsEh-1ZG-p2
I was looking at the code and noticed a lane that looked unused (no
git grepmatches`) and that had the same implementation of another one, which is instead in use in the codebase.Testing Steps
N.A. This only removes a duplicated lane.
Having said that, a successful prototype build will show that the code that was touched is still working.