Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QE Unit Tests II: Adding QuickEditorNoticeViewTests #680

Merged
merged 2 commits into from
Mar 31, 2025
Merged

QE Unit Tests II: Adding QuickEditorNoticeViewTests #680

merged 2 commits into from
Mar 31, 2025

Conversation

etoledom
Copy link
Contributor

Closes part of #539

Description

This PR adds snapshot tests to the QuickEditorNoticeView

Testing Steps

  • CI 🍏

@etoledom etoledom self-assigned this Mar 27, 2025
@wpmobilebot
Copy link

wpmobilebot commented Mar 27, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build
Build Number2152
VersionPR #680
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit7e31fac
Installation URL3nq0q4f5727j0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

pinarol
pinarol approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@etoledom etoledom merged commit 8bde65b into trunk Mar 31, 2025
8 checks passed
@etoledom etoledom deleted the etoledom/quick-editor-tests-mark-ii branch March 31, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@andrewdmontgomery andrewdmontgomery Awaiting requested review from andrewdmontgomery

Assignees

@etoledom etoledom

Labels
[Priority] Low Tech Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etoledom @wpmobilebot @pinarol