Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh podcast button to podcast player #26373

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

daledupreez
Copy link
Contributor

Changes proposed in this Pull Request:

  • This PR adds a "Refresh podcast" button to the podcast player for users with edit permissions on the underlying post
  • Under the covers this button calls the existing wpcom/v2/podcast-player API with a new force-refresh flag to allow users with edit_post permissions to force a podcast refresh

Screenshot 2022-09-23 at 11 53 04

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

p1HpG7-hQk-p2 especially this comment: p1HpG7-hQk-p2#comment-57214

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Use the Jetpack Beta plugin to get this code applied to your server
  • Add a post with a podcast player block to the post
  • Visit the public post while logged in
  • Verify that you can see the button, and that clicking on the button refreshes the podcast and reloads the page
  • Visit the public post while logged out
  • Verify that you don't see the button

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello daledupreez! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D88388-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack try/admin-controls-for-podcast-player to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [Block] Podcast Player [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: January 3, 2023.
  • Scheduled code freeze: December 26, 2022.

@daledupreez daledupreez force-pushed the try/admin-controls-for-podcast-player branch from 3da3e0f to 5d49530 Compare December 13, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants