Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/readme add jetpack ai #31140

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Improve/readme add jetpack ai #31140

merged 3 commits into from
Jun 2, 2023

Conversation

mikestottuk
Copy link
Contributor

@mikestottuk mikestottuk commented Jun 1, 2023

Proposed changes:

Add a new section to the readme to promote the new AI features.

Jetpack product discussion

pdhack-Fo-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Check for typos.

@mikestottuk mikestottuk self-assigned this Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack improve/readme-add-jetpack-ai

to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: July 5, 2023.
  • Scheduled code freeze: June 26, 2023.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 1, 2023
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Block] AI Assistant and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jun 1, 2023
@jeherve jeherve added this to the Jetpack/12.2 milestone Jun 1, 2023
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. Should we mention translations too?

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 1, 2023
@mikestottuk
Copy link
Contributor Author

This works for me. Should we mention translations too?

We probably can add it, if we do it might start making Jetpack rank as a “translations” plugin though (for front end of the site, like https://wordpress.org/plugins/weglot/ )

jeherve added a commit that referenced this pull request Jun 1, 2023
1. Adjust wording for the AI Assistant announcement, matching #31140.
2. Mention new Publicize to Mastodon and Instagram options.
@mikestottuk
Copy link
Contributor Author

@jeherve I've added in a bullet on translations (the copy for this is part of the launch materials - i.e. I've not just made it up)

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jun 2, 2023
@anomiex anomiex merged commit df4b533 into trunk Jun 2, 2023
@anomiex anomiex deleted the improve/readme-add-jetpack-ai branch June 2, 2023 17:44
anomiex pushed a commit that referenced this pull request Jun 2, 2023
* Jetpack AI added to the WP.org listing via the readme
* add translation power bullet
@anomiex
Copy link
Contributor

anomiex commented Jun 2, 2023

Cherry-picked as ea2d088

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 2, 2023
tbradsha pushed a commit that referenced this pull request Jun 2, 2023
* Jetpack AI added to the WP.org listing via the readme
* add translation power bullet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] AI Assistant [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants