Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: enable Odyssey Stats for WoA sites #35528

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Feb 8, 2024

Related: #35615

Proposed changes:

  • Enable Odyssey Stats for WoA (Atomic) sites

Atomic sites were using Calypso Stats before, but with the process of the untangling Calypso project going on, Atomic sites now have an option to stay within WP-Admin for (almost) everything. Atomic sites were intentionally left out when rolling out the new Stats experience (Odyssey Stats), and now it's the time to enable it.

The PR should be merged after all the parity work is finished at https://github.com/Automattic/jetpack-roadmap/issues/1204

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pfsHM7-5B-p2#comment-153

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Create an Atomic dev blog following instructions at p9o2xV-1r2-p2
  • Install Jetpack and Jetpack Beta plugin
  • Choose branch update/enable-odyssey-for-woa-sites in Jetpack Beta
  • Open /wp-admin/admin.php?page=stats
  • Ensure all the pages work okay

@kangzj kangzj added the Stats label Feb 8, 2024
@kangzj kangzj self-assigned this Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/enable-odyssey-for-woa-sites branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/enable-odyssey-for-woa-sites
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for March 5, 2024 (scheduled code freeze on March 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@kangzj kangzj requested review from a team and iamgabrielma February 13, 2024 01:03
@kangzj kangzj added the DO NOT MERGE don't merge it! label Feb 13, 2024
@kangzj kangzj requested review from lupus2k and removed request for iamgabrielma February 13, 2024 03:09
Copy link
Contributor

@lupus2k lupus2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@a8ck3n a8ck3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me with the exception of a handful of 404s on the Subscribers page. It looks like the launchpad-related APIs are not available here.

@jeherve jeherve added [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. and removed Stats labels Feb 19, 2024
@kangzj kangzj marked this pull request as ready for review February 22, 2024 20:55
@kangzj kangzj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress DO NOT MERGE don't merge it! labels Feb 22, 2024
@kangzj kangzj enabled auto-merge (squash) February 28, 2024 20:12
@kangzj kangzj merged commit 8c0f602 into trunk Feb 28, 2024
52 checks passed
@kangzj kangzj deleted the update/enable-odyssey-for-woa-sites branch February 28, 2024 20:18
@github-actions github-actions bot added this to the jetpack/13.2 milestone Feb 28, 2024
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants