Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Update CSS minification library #40956

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Jan 10, 2025

There was a bug in the old minification library, which caused a concatenated CSS file to be loaded very slowly.

This only happened when a website was running on a server with Brotli encoding, Jetpack Boost with Concatenate CSS enabled and the Responsive Blocks - WordPress Gutenberg Blocks plugin.

Related p1736444901637029-slack-C7YPW6K40

Proposed changes:

  • Replace CSS minification library. We already had the library minifying JS, it's now also minifying CSS;
  • Remove old minification library.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1736444901637029-slack-C7YPW6K40

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Pre-requisites

  • A website on a server with Brotli encoding (atomic sites are great for this);
  • The Responsive Blocks - WordPress Gutenberg Blocks plugin running on the website;

Test that it breaks

  • Setup Jetpack Boost production;
  • Enable Concatenate CSS;
  • Load the home page and observe the network requests. There should be one request (that contains _jb_static) that takes too long (around 40 seconds).

Test that it works

  • Setup Jetpack Boost from this branch;
  • Enable Concatenate CSS;
  • Load the home page and observe the network requests. There should be no _jb_static requests that take too long.

@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress labels Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 10, 2025
@dilirity dilirity self-assigned this Jan 10, 2025
@dilirity dilirity added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 10, 2025
@dilirity dilirity added this to the boost/next milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Minify [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress [Status] Needs Team Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant