WPAdmin always loads Odyssey Stats widget regardless of "wpcom_admin_interface"

[dognose24]

Fixes #40412

Proposed changes:

• After tackling removing the legacy Stats widget on Jetpack, the legacy Stats widget on the WPAdmin Dashboard of Simple sites from the original issue still shows, which was actually loaded by wpcom admin plugins and should be removed as it's outdated: 169721-ghe-Automattic/wpcom.
• On the other hand, to have an alternative Stats widget even for the unexpected path, it seems fine to always load Jetpack_Stats_Dashboard_Widget regardless of the wpcom_admin_interface settings. Context: p1736405729895379/1734418687.010599-slack-C06DN6QQVAQ.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Build changes with jetpack build packages/jetpack-mu-wpcom plugins/mu-wpcom-plugin.
• cd projects/plugins/mu-wpcom-plugin/.
• Check out the sandbox branch to 169721-ghe-Automattic/wpcom.
• Sync Jetpack build to sandbox: jetpack rsync mu-wpcom-plugin {sandbox-user}@{sandbox-hostname}:/path-to/wp-content/mu-plugins/jetpack-mu-wpcom-plugin/production.
• Sandbox a testing Simple site on the local hosts file.
• Navigate to the testing Simple site.
• Ensure the Settings > General > Admin interface style is set to Default style.

• Go to the WPAdmin Dashboard by directly typing on the URL: https://{your-site}.wordpress.com/wp-admin.
• Ensure the latest Odyssey Stats widget is loaded.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/wpadmin_always_loads_odyssey_stats_widget branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/wpadmin_always_loads_odyssey_stats_widget
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Mu Wpcom plugin:

• Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[mmtr]

Nice! I see the Odyssey Stats widget is loaded, but the legacy one is also still visible and stuck on a loading state:

Before	After

[dognose24]

but the legacy one is also still visible and stuck on a loading state

Thanks for the review, @mmtr! The better testing instruction should be updated to check out the sandbox branch to 169721-ghe-Automattic/wpcom first, as the PR should be shipped before this one when deploying.

[mmtr]

@dognose24 that makes sense, thanks for the extra details. Everything looks good now:

[ellatrix]

I'm still seeing the old one. Am I missing something? Manually went to wp-admin with default style selected.

[mmtr]

The better testing instruction should be updated to check out the sandbox branch to 169721-ghe-Automattic/wpcom first, as the PR should be shipped before this one when deploying.

I see the counterpart wpcom PR is still open. Did we merge this first by mistake? @dognose24 what's needed to deploy 169721-ghe-Automattic/wpcom ?

[dognose24]

I'm still seeing the old one.

It's expected until we merge the counterpart WPCOM PR (169721-ghe-Automattic/wpcom) to remove the legacy one.

We have discussed whether we need to add a feature gate to the modern Stats widget, as we did on Jetpack Stats. (Context: p1736803435008119-slack-C068X5XJT3J) However, the upsell issue also affects sites without Jetpack Stats purchases rather than just the particular case from the originally reported issue. I would prefer to ship the relevant PRs and follow up on adding upsells to the Stats widget. cc @kangzj

[dognose24]

I'm still seeing the old one. Am I missing something? Manually went to wp-admin with default style selected.

The PR to remove the legacy Stats widget is live now. So, users will never see the old one from now on. cc @ellatrix @mmtr @kangzj