Post editor: Deprecate welcome guide in favor of the core one #41258

xavier-lc · 2025-01-22T16:57:25Z

Fixes https://github.com/Automattic/dotcom-forge/issues/8765

Proposed changes:

On https://github.com/Automattic/dotcom-forge/issues/8765#issuecomment-2500448699 it was decided to drop the WelcomeGuide component that's shown when users get to the post editor for the first time, and show the one used on core instead.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Apply this patch on your sandbox
Create a new account, and with it, create a new site without getting to launch it
Sandbox the new site
Go to /post/{siteSlug}.wordpress.com
Check that you see the welcome guide from core instead of the custom one:

Before	After

github-actions · 2025-01-22T16:58:21Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Mu Wpcom plugin:

Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-01-22T17:11:10Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/deprecate-welcome-guide-in-favor-of-the-core-one branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/deprecate-welcome-guide-in-favor-of-the-core-one

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

xavier-lc · 2025-01-22T18:06:15Z

projects/packages/jetpack-mu-wpcom/src/features/wpcom-block-editor-nux/src/disable-core-nux.js

@@ -5,10 +5,6 @@ import '@wordpress/nux'; //ensure nux store loads
 // Disable nux and welcome guide features from core.
 const unsubscribe = subscribe( () => {
 	dispatch( 'core/nux' ).disableTips();
-	if ( select( 'core/edit-post' )?.isFeatureActive( 'welcomeGuide' ) ) {
-		dispatch( 'core/edit-post' ).toggleFeature( 'welcomeGuide' );


Prevent the disabling of the core welcome guide

Should we also disable preventing the core welcome guide on core/edit-site since it's also the editor?

xavier-lc · 2025-01-22T18:06:26Z

projects/packages/jetpack-mu-wpcom/src/features/wpcom-block-editor-nux/src/disable-core-nux.js

@@ -22,16 +18,7 @@ subscribe( () => {
 		dispatch( 'core/nux' ).disableTips();
 		dispatch( 'automattic/wpcom-welcome-guide' ).setShowWelcomeGuide( true );
 	}
-	if ( select( 'core/edit-post' )?.isFeatureActive( 'welcomeGuide' ) ) {
-		dispatch( 'core/edit-post' ).toggleFeature( 'welcomeGuide' );


Prevent the disabling of the core welcome guide

Same as above.

rcrdortiz

Works as expected

github-actions bot added [mu wpcom Feature] Wpcom Block Editor Nux [Package] Jetpack mu wpcom WordPress.com Features [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh [Tests] Includes Tests labels Jan 22, 2025

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 22, 2025

Xavier Lozano Carreras added 3 commits January 22, 2025 18:09

Stop disabling the core welcome guide

65a8790

Remove the custom WelcomeTour

0092b22

changelog

7e486b2

xavier-lc force-pushed the update/deprecate-welcome-guide-in-favor-of-the-core-one branch from 2c4228c to 7e486b2 Compare January 22, 2025 17:10

xavier-lc mentioned this pull request Jan 22, 2025

Update/rm welcome tour #40344

Closed

3 tasks

xavier-lc changed the title ~~Update/deprecate welcome guide in favor of the core one~~ Post editor: Deprecate welcome guide in favor of the core one Jan 22, 2025

xavier-lc self-assigned this Jan 22, 2025

kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 22, 2025

xavier-lc commented Jan 22, 2025

View reviewed changes

xavier-lc requested a review from a team January 22, 2025 18:06

rcrdortiz approved these changes Jan 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Post editor: Deprecate welcome guide in favor of the core one #41258

Post editor: Deprecate welcome guide in favor of the core one #41258

xavier-lc commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

xavier-lc Jan 22, 2025

rcrdortiz Jan 23, 2025

xavier-lc Jan 22, 2025

rcrdortiz Jan 23, 2025

rcrdortiz left a comment

Post editor: Deprecate welcome guide in favor of the core one #41258

Are you sure you want to change the base?

Post editor: Deprecate welcome guide in favor of the core one #41258

Conversation

xavier-lc commented Jan 22, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 22, 2025 • edited Loading

github-actions bot commented Jan 22, 2025 • edited Loading

xavier-lc Jan 22, 2025

Choose a reason for hiding this comment

rcrdortiz Jan 23, 2025

Choose a reason for hiding this comment

xavier-lc Jan 22, 2025

Choose a reason for hiding this comment

rcrdortiz Jan 23, 2025

Choose a reason for hiding this comment

rcrdortiz left a comment

Choose a reason for hiding this comment

xavier-lc commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading