Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Prioritized Cloud CSS regeneration for cornerstone pages #41516

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

haqadn
Copy link
Contributor

@haqadn haqadn commented Feb 3, 2025

Proposed changes:

  • Specify C.CSS regeneration reason when a cornerstone page is updated
  • Regenerate cloud CSS if the cornerstone pages list is updated

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

None

Testing instructions:

  • Upgrade Boost.
  • Update the cornerstone pages list.
  • Update one of the cornerstone pages.
  • Make sure cloud CSS is requested with reason cornerstone_update

@haqadn haqadn added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Feb 3, 2025
@haqadn haqadn requested a review from a team February 3, 2025 19:42
@haqadn haqadn self-assigned this Feb 3, 2025
@github-actions github-actions bot added [Boost Feature] Cloud CSS [Plugin] Boost A feature to speed up the site and improve performance. labels Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@haqadn haqadn changed the title Update parameter description Boost: Prioritized Cloud CSS regeneration for cornerstone pages Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/modules/optimizations/cloud-css/Cloud_CSS.php 0/83 (0.00%) 0.00% 5 💔
projects/plugins/boost/app/rest-api/endpoints/List_Cornerstone_Pages.php 0/6 (0.00%) 0.00% -1 💚
projects/plugins/boost/app/lib/critical-css/source-providers/providers/Cornerstone_Provider.php 0/31 (0.00%) 0.00% -2 💚
projects/plugins/boost/app/lib/Environment_Change_Detector.php 0/33 (0.00%) 0.00% -4 💚

2 files are newly covered.

File Coverage
projects/plugins/boost/app/lib/cornerstone/Cornerstone_Pages.php 0/63 (0.00%) 💔
projects/plugins/boost/app/lib/cornerstone/Cornerstone_Utils.php 0/11 (0.00%) 💔

Full summary · PHP report · JS report

@dilirity dilirity added this to the boost/next milestone Feb 4, 2025
Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work cleaning repetitive code up!

I've fixed a PHAN complaint in 8321808.

:shipit:

@haqadn haqadn merged commit c2b0cc1 into trunk Feb 4, 2025
66 checks passed
@haqadn haqadn deleted the update/ccss-regeneration branch February 4, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Cloud CSS [Plugin] Boost A feature to speed up the site and improve performance. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants