-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: Add File Upload Field Skeleton (Experimental) #41582
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:
Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 3 files.
|
* | ||
* @return string HTML for the file upload field. | ||
*/ | ||
public static function gutenblock_render_field_file( $atts, $content ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beside changing this. We will also have to change the markup of the form html and add
enctype="multipart/form-data"
This works as described. 🥳
I can see the new form filed. With
I don't. Some things that I noticed that we can address in future PRs.
|
Definitely! Plenty of room for improvement in follow-ups. 😄 This was more about enabling the experimental flag for the field. |
Proposed changes:
Implementation Details:
field-file
block definition with experimental flagTesting instructions:
Testing the Block Structure:
JETPACK_BLOCKS_VARIATION
to 'experimental'Verifying Experimental Gate:
JETPACK_BLOCKS_VARIATION
to anything other than 'experimental'