-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep both raw and formatted value on keywords step #41641
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
Proposed changes:
This PR splits the value on keywords step (input step) so to keep the value as the user entered but also the formatted version (cleaned up, comma separated string of keywords) to provide on later steps. This way, the steps don't have to perform the same cleanup, trusting the value will just be a string,with,values,separated,by,commas. It also makes for a single point of processing the user input string.
Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
As the state of things are right now, nothing should have changed. Both title and meta steps will receive the formatted value, but the keywords step will retain both.
You can enable debug (
setLocalStorage( 'debug', 'jetpack-seo:*' )
) and check the value vs the input text:Input text:
,,dogs, , cats, some multi word keyword