-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDV: Sync calypso preference for a12s #41710
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Backup plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Search plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Social plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Starter Plugin plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Automattic For agencies client plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-interface/wpcom-admin-interface.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the following:
- Prepared an inconsistent RDV assignment between Calypso (
control
) and Jetpack (treatment
) by manually settingcontrol
via 22167-explat-experiment. - Applied the patch on Atomic
- Navigated to
wp-admin/options-general.php
. - Observed a consistent assignment (
treatment
) b/w Calypso and Jetpack - Assigned
control
using the escape hatch. - Verified the
control
behavior. - Assigned
treatment
using the escape hatch. - Verified the
treatment
behavior. - Cleared the Calypso preference by executing the following in the Console:
{"remove_duplicate_views_experiment_assignment_160125": null}
- Confirmed that the
treatment
behavior persists.
LGTM on changes!
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-interface/wpcom-admin-interface.php
Show resolved
Hide resolved
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-interface/wpcom-admin-interface.php
Show resolved
Hide resolved
63a7f3a
to
453ab00
Compare
a12s are assigned in our client code the treatment variation - variation which is cached in an option. However, the variation was not also passed in the calypso preferences.
While this wasn't a major problem in the past, this is now causing problems because the Calypso preference is now used in other contexts.
Since the assignment variation is cached in a user option, short-circuiting the code, we also need a way to dynamically purge the cache for a12s so that the calypso preference is configured.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
die('purged')
inwpcom_rdv_reset_cache_if_needed
, on line 403, after delete_user_optiondie('cached')
on line 460purged
cache
text