-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Improve 404 handler URL path processing #41731
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I love that you use content_url() to build a safe url for the file.
I spoke too soon. If a URL has a directory in it, then site_url() adds the directory to dirname, which will already have the directory. For example: "/blog/blog/wp-content/boost-cache/static/" |
Proposed changes:
Other information:
Jetpack product discussion
p1739291038738559-slack-C016BBAFHHS
Does this pull request change what data or activity we track or use?
None
Testing instructions:
ABSPATH
. So, previously static file handlers would not work in JN.wp-content/boost-cache/static/