Forms: add min/max options to number field #41783

simison · 2025-02-13T12:27:25Z

Part of #40961

Proposed changes:

Adds min/max options to number field

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Add number field
You can use positive/negative numbers without max/min set
You can limit values you can set by min/max options
Test that minimum value must be less than or equal to the value of the max attribute
Test that maximum value must be greater than or equal to the value of the min attribute

github-actions · 2025-02-13T12:28:18Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/forms-number-field-options branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-number-field-options

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-02-13T12:28:38Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-02-13T12:36:11Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/blocks/contact-form/child-blocks.js	0/68 (0.00%)	0.00%	3 ❤️‍🩹

1 file is newly checked for coverage.

File	Coverage
projects/packages/forms/src/blocks/contact-form/components/jetpack-field-number.js	0/19 (0.00%) 💔

Full summary · PHP report · JS report

_{Add label

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
to override the failing coverage check.}

jp-launch-control · 2025-02-13T22:12:57Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-field.php	346/515 (67.18%)	-0.27%	4 💔
projects/packages/forms/src/blocks/contact-form/child-blocks.js	0/68 (0.00%)	0.00%	3 ❤️‍🩹

1 file is newly checked for coverage.

File	Coverage
projects/packages/forms/src/blocks/contact-form/components/jetpack-field-number.js	0/19 (0.00%) 💔

Full summary · PHP report · JS report

_{Add label

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
to override the failing coverage check.}

simison · 2025-02-14T13:59:25Z

projects/packages/forms/src/blocks/contact-form/components/jetpack-field-number.js

+				placeholder={ placeholder }
+				attributes={ attributes }
+				hidePlaceholder={ true }
+				extraFieldSettings={ [


Quite dislike adding this whole file just to add two fields under extraFieldSettings.

Could potentially be done differently, directly in jetpack-field.js with conditionally by importing the settings only from another file. 🤔

Fine to do either in this PR or in a follow-up later on.

Might make sense to keep these files separate as we migrate towrds child-blocks for fields. Mixing the fields into one file might complicate the migration.

simison · 2025-02-14T14:00:01Z

projects/packages/forms/src/blocks/contact-form/components/jetpack-field-number.js

+					type="number"
+					value={ placeholder }
+					min={ min }
+					max={ max }


These min/max are also a difference from jetpack-field.js. And fixed type="number" but that was non issue already before, it was just added dynamically with type prop.

lezama · 2025-02-14T16:16:46Z

I am getting this error when adding the number field to a default contact form:

react.js?ver=18:199 Warning: Each child in a list should have a unique "key" prop.

Check the render method of `JetpackFieldControls`. It was passed a child from JetpackNumberField. See https://reactjs.org/link/warning-keys for more information.
    at UnforwardedNumberControl (https://asjdfnasdnfalsjf.jurassic.tube/wp-content/plugins/gutenberg/build/components/index.min.js?ver=a8d73b4c01db0cc020f6:35976:100)
    at JetpackFieldControls (https://aksdnfalskndf.jurassic.tube/wp-content/plugins/jetpack/jetpack_vendor/automattic/jetpack-forms/dist/blocks/editor.js?minify=false&ver=85a55809248183edf43e:7251:3)

simison added [Status] In Progress [Package] Forms [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Type] Feature Development of a new feature labels Feb 13, 2025

simison mentioned this pull request Feb 13, 2025

Forms: number field #40961

Open

8 tasks

github-actions bot added [Block] AI Assistant [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Docs labels Feb 13, 2025

simison force-pushed the update/forms-number-field-options branch from dd8ad36 to 2564025 Compare February 13, 2025 18:03

simison marked this pull request as ready for review February 13, 2025 18:04

simison added [Status] Needs Team Review and removed [Status] In Progress Docs [Block] AI Assistant labels Feb 13, 2025

simison requested a review from a team February 13, 2025 18:04

github-actions bot added the [Status] In Progress label Feb 13, 2025

simison removed the [Status] Needs Team Review label Feb 13, 2025

simison force-pushed the update/forms-number-field-options branch from 2564025 to b819f03 Compare February 13, 2025 22:03

simison mentioned this pull request Feb 14, 2025

Forms: range field #41810

Open

4 tasks

simison added 3 commits February 14, 2025 15:54

Forms: add min/max options to number field

c038a7f

changelog

439bf84

Frontend rendering min/max

ffad0e1

simison force-pushed the update/forms-number-field-options branch from b819f03 to ffad0e1 Compare February 14, 2025 13:55

simison removed the [Status] In Progress label Feb 14, 2025

simison added the [Status] Needs Team Review label Feb 14, 2025

simison commented Feb 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forms: add min/max options to number field #41783

Forms: add min/max options to number field #41783

simison commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

jp-launch-control bot commented Feb 13, 2025 •

edited

Loading

simison Feb 14, 2025 •

edited

Loading

simison Feb 14, 2025 •

edited

Loading

lezama commented Feb 14, 2025

Forms: add min/max options to number field #41783

Are you sure you want to change the base?

Forms: add min/max options to number field #41783

Conversation

simison commented Feb 13, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Feb 13, 2025 • edited Loading

github-actions bot commented Feb 13, 2025 • edited Loading

github-actions bot commented Feb 13, 2025 • edited Loading

Code Coverage Summary

jp-launch-control bot commented Feb 13, 2025 • edited Loading

Code Coverage Summary

simison Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

simison Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

lezama commented Feb 14, 2025

simison commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

jp-launch-control bot commented Feb 13, 2025 •

edited

Loading

simison Feb 14, 2025 •

edited

Loading

simison Feb 14, 2025 •

edited

Loading