Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter Dashboard widget: enqueue styles and add config data for footer links #41903

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

holdercp
Copy link
Contributor

@holdercp holdercp commented Feb 19, 2025

Related to Automattic/loop#451

Proposed changes:

  • Enqueues the widget styles from the Calypso app
  • Adds config data needed to render the footer links

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Jetpack/WOA sites.

  • Add the constant define( 'JETPACK_NEWSLETTER_WIDGET', true ); to your wp-config.php file if you're testing this on local.
  • For WOA sites, this constant can be set in the wp-config file which lives in a file like this ~/htdocs/wp-config.php.
  • Similarly for JN sites, you can do this same thing. Your JN site's wp-admin has the ssh creds you will need to update the wp-config.php file to set the JETPACK_NEWSLETTER_WIDGET constant.
  • Make sure this Jetpack branch is active using the Jetpack Beta plugin
  • Sandbox widget.wp.com and public-api
  • Build the Calypso app from this branch following this guide: pg9MHR-ox-p2.
  • Go to wp-admin to see the widget and the footer section
  • Verify all links work as expected

Simple sites

  • Follow the steps here to prepare your sandbox.
  • Build the Calypso app if you didn't in the section above.
  • In your 0-sandbox.php, Add the constant define( 'JETPACK_NEWSLETTER_WIDGET', true );
  • Sandbox your simple site, public-api.wordpress.com, and widgets.wp.com
  • Go to wp-admin to see the widget and the footer section
  • Verify all links work as expected

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/newsletter-widget-footer branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/newsletter-widget-footer

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 19, 2025
Copy link

jp-launch-control bot commented Feb 19, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@holdercp holdercp changed the title Add/newsletter widget footer Newsletter Dashboard Widget: enqueue styles and add config data for footer Feb 21, 2025
@holdercp holdercp changed the title Newsletter Dashboard Widget: enqueue styles and add config data for footer Newsletter Dashboard widget: enqueue styles and add config data for footer links Feb 21, 2025
@holdercp holdercp added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Your teammate needs to review this PR. labels Feb 21, 2025
@holdercp holdercp marked this pull request as ready for review February 21, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Team Review Your teammate needs to review this PR. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant